Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replied to comments, added browser tests, rebased. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
index 7cbc67bb7ac92f50c66541ee1dff2d3e84dba1f7..3d6208426408843e78f4f4cd83e79b8688a8ccfb 100644
--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc
+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
@@ -36,7 +36,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(1U, languages.size());
EXPECT_EQ("en-US", languages[0]);
@@ -49,7 +49,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(1U, languages.size());
EXPECT_EQ("en-US", languages[0]);
@@ -63,7 +63,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(2U, languages.size());
@@ -80,7 +80,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(2U, languages.size());
@@ -98,8 +98,21 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "fr", &languages);
+ accept_languages, &languages);
EXPECT_EQ(1U, languages.size());
EXPECT_EQ("fr", languages[0]);
}
+
+TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages6) {
+ std::vector<std::string> accept_languages;
+ accept_languages.push_back("en-AU");
+ accept_languages.push_back("en-US");
+ accept_languages.push_back("fr");
+
+ std::vector<std::string> languages;
+ languages.push_back("fr");
+
+ SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
+ accept_languages, &languages);
+}

Powered by Google App Engine
This is Rietveld 408576698