Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replied to comments, added browser tests, rebased. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/spellchecker/spellcheck_service.h" 5 #include "chrome/browser/spellchecker/spellcheck_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "chrome/browser/spellchecker/feedback_sender.h" 9 #include "chrome/browser/spellchecker/feedback_sender.h"
10 #include "chrome/browser/spellchecker/spellcheck_factory.h" 10 #include "chrome/browser/spellchecker/spellcheck_factory.h"
(...skipping 18 matching lines...) Expand all
29 TestingProfile profile_; 29 TestingProfile profile_;
30 }; 30 };
31 31
32 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) { 32 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {
33 std::vector<std::string> accept_languages; 33 std::vector<std::string> accept_languages;
34 accept_languages.push_back("en"); 34 accept_languages.push_back("en");
35 accept_languages.push_back("en-US"); 35 accept_languages.push_back("en-US");
36 std::vector<std::string> languages; 36 std::vector<std::string> languages;
37 37
38 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages( 38 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
39 accept_languages, "en-US", &languages); 39 accept_languages, &languages);
40 40
41 EXPECT_EQ(1U, languages.size()); 41 EXPECT_EQ(1U, languages.size());
42 EXPECT_EQ("en-US", languages[0]); 42 EXPECT_EQ("en-US", languages[0]);
43 } 43 }
44 44
45 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) { 45 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
46 std::vector<std::string> accept_languages; 46 std::vector<std::string> accept_languages;
47 accept_languages.push_back("en-US"); 47 accept_languages.push_back("en-US");
48 accept_languages.push_back("en"); 48 accept_languages.push_back("en");
49 std::vector<std::string> languages; 49 std::vector<std::string> languages;
50 50
51 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages( 51 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
52 accept_languages, "en-US", &languages); 52 accept_languages, &languages);
53 53
54 EXPECT_EQ(1U, languages.size()); 54 EXPECT_EQ(1U, languages.size());
55 EXPECT_EQ("en-US", languages[0]); 55 EXPECT_EQ("en-US", languages[0]);
56 } 56 }
57 57
58 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) { 58 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
59 std::vector<std::string> accept_languages; 59 std::vector<std::string> accept_languages;
60 accept_languages.push_back("en"); 60 accept_languages.push_back("en");
61 accept_languages.push_back("en-US"); 61 accept_languages.push_back("en-US");
62 accept_languages.push_back("en-AU"); 62 accept_languages.push_back("en-AU");
63 std::vector<std::string> languages; 63 std::vector<std::string> languages;
64 64
65 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages( 65 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
66 accept_languages, "en-US", &languages); 66 accept_languages, &languages);
67 67
68 EXPECT_EQ(2U, languages.size()); 68 EXPECT_EQ(2U, languages.size());
69 69
70 std::sort(languages.begin(), languages.end()); 70 std::sort(languages.begin(), languages.end());
71 EXPECT_EQ("en-AU", languages[0]); 71 EXPECT_EQ("en-AU", languages[0]);
72 EXPECT_EQ("en-US", languages[1]); 72 EXPECT_EQ("en-US", languages[1]);
73 } 73 }
74 74
75 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) { 75 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
76 std::vector<std::string> accept_languages; 76 std::vector<std::string> accept_languages;
77 accept_languages.push_back("en"); 77 accept_languages.push_back("en");
78 accept_languages.push_back("en-US"); 78 accept_languages.push_back("en-US");
79 accept_languages.push_back("fr"); 79 accept_languages.push_back("fr");
80 std::vector<std::string> languages; 80 std::vector<std::string> languages;
81 81
82 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages( 82 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
83 accept_languages, "en-US", &languages); 83 accept_languages, &languages);
84 84
85 EXPECT_EQ(2U, languages.size()); 85 EXPECT_EQ(2U, languages.size());
86 86
87 std::sort(languages.begin(), languages.end()); 87 std::sort(languages.begin(), languages.end());
88 EXPECT_EQ("en-US", languages[0]); 88 EXPECT_EQ("en-US", languages[0]);
89 EXPECT_EQ("fr", languages[1]); 89 EXPECT_EQ("fr", languages[1]);
90 } 90 }
91 91
92 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) { 92 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
93 std::vector<std::string> accept_languages; 93 std::vector<std::string> accept_languages;
94 accept_languages.push_back("en"); 94 accept_languages.push_back("en");
95 accept_languages.push_back("en-JP"); // Will not exist. 95 accept_languages.push_back("en-JP"); // Will not exist.
96 accept_languages.push_back("fr"); 96 accept_languages.push_back("fr");
97 accept_languages.push_back("aa"); // Will not exist. 97 accept_languages.push_back("aa"); // Will not exist.
98 std::vector<std::string> languages; 98 std::vector<std::string> languages;
99 99
100 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages( 100 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
101 accept_languages, "fr", &languages); 101 accept_languages, &languages);
102 102
103 EXPECT_EQ(1U, languages.size()); 103 EXPECT_EQ(1U, languages.size());
104 EXPECT_EQ("fr", languages[0]); 104 EXPECT_EQ("fr", languages[0]);
105 } 105 }
106
107 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages6) {
108 std::vector<std::string> accept_languages;
109 accept_languages.push_back("en-AU");
110 accept_languages.push_back("en-US");
111 accept_languages.push_back("fr");
112
113 std::vector<std::string> languages;
114 languages.push_back("fr");
115
116 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
117 accept_languages, &languages);
118 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698