Index: chrome/browser/spellchecker/spellcheck_service.h |
diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h |
index c7229e8b468b03a55676e5ad7ab141c84c5f89cb..a199290ca7d75196c7140bf73af3bad4746a91df 100644 |
--- a/chrome/browser/spellchecker/spellcheck_service.h |
+++ b/chrome/browser/spellchecker/spellcheck_service.h |
@@ -63,19 +63,20 @@ class SpellcheckService : public KeyedService, |
base::WeakPtr<SpellcheckService> GetWeakPtr(); |
- // This function computes a vector of strings which are to be displayed in |
- // the context menu over a text area for changing spell check languages. It |
- // returns the index of the current spell check language in the vector. |
+ // This function computes a vector of strings, |languages| which are to be |
+ // displayed in the context menu over a text area for changing spell check |
+ // languages. It returns the number of current spell check languages in |
+ // |languages|. |
please use gerrit instead
2015/06/04 19:41:06
s/current/enabled
Explain why the return value is
Julius
2015/06/05 03:41:13
Done.
|
// TODO(port): this should take a vector of base::string16, but the |
// implementation has some dependencies in l10n util that need porting first. |
- static int GetSpellCheckLanguages(content::BrowserContext* context, |
- std::vector<std::string>* languages); |
+ static int GetSpellCheckLanguages( |
please use gerrit instead
2015/06/04 19:41:05
Since you're returning the number of the first |la
Julius
2015/06/05 03:41:12
Done.
|
+ content::BrowserContext* context, |
please use gerrit instead
2015/06/04 19:41:06
Can you make this pointer "const" to clarify that
Julius
2015/06/05 03:41:12
Done.
|
+ std::vector<std::string>* languages); |
// Computes a vector of strings which are to be displayed in the context |
- // menu from |accept_languages| and |dictionary_language|. |
+ // menu from |accept_languages| and |dictionary_languages|. |
static void GetSpellCheckLanguagesFromAcceptLanguages( |
please use gerrit instead
2015/06/04 19:41:06
Inline this function's code into GetSpellCheckLang
Julius
2015/06/05 03:41:13
Done.
|
const std::vector<std::string>& accept_languages, |
- const std::string& dictionary_language, |
std::vector<std::string>* languages); |
// Signals the event attached by AttachTestEvent() to report the specified |