Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 45 matching lines @@
     DICT_HUNSPELL,
     DICT_TEXT,
     DICT_UNKNOWN,
   };
 
   explicit SpellcheckService(content::BrowserContext* context);
   ~SpellcheckService() override;
 
   base::WeakPtr<SpellcheckService> GetWeakPtr();
 
-  // This function computes a vector of strings which are to be displayed in
-  // the context menu over a text area for changing spell check languages. It
-  // returns the index of the current spell check language in the vector.
+  // This function computes a vector of strings, |languages| which are to be
+  // displayed in the context menu over a text area for changing spell check
+  // languages. It returns the number of current spell check languages in
+  // |languages|.

[please use gerrit instead, 2015/06/04 19:41:06]

s/current/enabled

Explain why the return value is useful and sufficient. Why is std::set<> or
std::vector<> of indices into |languages| not returned here? (The source file
has a comment that explain this. That comment should be moved here.)

[Julius, 2015/06/05 03:41:13]

Done.

   // TODO(port): this should take a vector of base::string16, but the
   // implementation has some dependencies in l10n util that need porting first.
-  static int GetSpellCheckLanguages(content::BrowserContext* context,
-                                    std::vector<std::string>* languages);
+  static int GetSpellCheckLanguages(

[please use gerrit instead, 2015/06/04 19:41:05]

Since you're returning the number of the first |languages| items that are
enabled spellcheck languages, you should change the return type to "size_t".

No need to change formatting.

[Julius, 2015/06/05 03:41:12]

Done.

+      content::BrowserContext* context,

[please use gerrit instead, 2015/06/04 19:41:06]

Can you make this pointer "const" to clarify that this is a read-only function?

[Julius, 2015/06/05 03:41:12]

Done.

+      std::vector<std::string>* languages);
 
   // Computes a vector of strings which are to be displayed in the context
-  // menu from |accept_languages| and |dictionary_language|.
+  // menu from |accept_languages| and |dictionary_languages|.
   static void GetSpellCheckLanguagesFromAcceptLanguages(

[please use gerrit instead, 2015/06/04 19:41:06]

Inline this function's code into GetSpellCheckLanguages. It's not used anywhere
else.

[Julius, 2015/06/05 03:41:13]

Done.

       const std::vector<std::string>& accept_languages,
-      const std::string& dictionary_language,
       std::vector<std::string>* languages);
 
   // Signals the event attached by AttachTestEvent() to report the specified
   // event to browser tests. This function is called by this class and its
   // derived classes to report their status. This function does not do anything
   // when we do not set an event to |status_event_|.
   static bool SignalStatusEvent(EventType type);
 
   // Instantiates SpellCheckHostMetrics object and makes it ready for recording
   // metrics. This should be called only if the metrics recording is active.
@@ skipping 83 matching lines @@
   scoped_ptr<SpellcheckHunspellDictionary> hunspell_dictionary_;
 
   scoped_ptr<spellcheck::FeedbackSender> feedback_sender_;
 
   base::WeakPtrFactory<SpellcheckService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SpellcheckService);
 };
 
 #endif  // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_