Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed previous comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/spellchecker/spellcheck_service.h" 5 #include "chrome/browser/spellchecker/spellcheck_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "chrome/browser/spellchecker/feedback_sender.h" 9 #include "chrome/browser/spellchecker/feedback_sender.h"
10 #include "chrome/browser/spellchecker/spellcheck_factory.h" 10 #include "chrome/browser/spellchecker/spellcheck_factory.h"
(...skipping 10 matching lines...) Expand all
21 void SetUp() override { 21 void SetUp() override {
22 // Use SetTestingFactoryAndUse to force creation and initialization. 22 // Use SetTestingFactoryAndUse to force creation and initialization.
23 SpellcheckServiceFactory::GetInstance()->SetTestingFactoryAndUse( 23 SpellcheckServiceFactory::GetInstance()->SetTestingFactoryAndUse(
24 &profile_, &BuildSpellcheckService); 24 &profile_, &BuildSpellcheckService);
25 } 25 }
26 26
27 private: 27 private:
28 content::TestBrowserThreadBundle thread_bundle_; 28 content::TestBrowserThreadBundle thread_bundle_;
29 TestingProfile profile_; 29 TestingProfile profile_;
30 }; 30 };
31
32 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {
please use gerrit instead 2015/06/06 01:42:13 Please port these tests to your new browser tests.
Julius 2015/06/12 20:10:15 Done.
33 std::vector<std::string> accept_languages;
34 accept_languages.push_back("en");
35 accept_languages.push_back("en-US");
36 std::vector<std::string> languages;
37
38 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
39 accept_languages, "en-US", &languages);
40
41 EXPECT_EQ(1U, languages.size());
42 EXPECT_EQ("en-US", languages[0]);
43 }
44
45 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
46 std::vector<std::string> accept_languages;
47 accept_languages.push_back("en-US");
48 accept_languages.push_back("en");
49 std::vector<std::string> languages;
50
51 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
52 accept_languages, "en-US", &languages);
53
54 EXPECT_EQ(1U, languages.size());
55 EXPECT_EQ("en-US", languages[0]);
56 }
57
58 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
59 std::vector<std::string> accept_languages;
60 accept_languages.push_back("en");
61 accept_languages.push_back("en-US");
62 accept_languages.push_back("en-AU");
63 std::vector<std::string> languages;
64
65 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
66 accept_languages, "en-US", &languages);
67
68 EXPECT_EQ(2U, languages.size());
69
70 std::sort(languages.begin(), languages.end());
71 EXPECT_EQ("en-AU", languages[0]);
72 EXPECT_EQ("en-US", languages[1]);
73 }
74
75 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
76 std::vector<std::string> accept_languages;
77 accept_languages.push_back("en");
78 accept_languages.push_back("en-US");
79 accept_languages.push_back("fr");
80 std::vector<std::string> languages;
81
82 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
83 accept_languages, "en-US", &languages);
84
85 EXPECT_EQ(2U, languages.size());
86
87 std::sort(languages.begin(), languages.end());
88 EXPECT_EQ("en-US", languages[0]);
89 EXPECT_EQ("fr", languages[1]);
90 }
91
92 TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
93 std::vector<std::string> accept_languages;
94 accept_languages.push_back("en");
95 accept_languages.push_back("en-JP"); // Will not exist.
96 accept_languages.push_back("fr");
97 accept_languages.push_back("aa"); // Will not exist.
98 std::vector<std::string> languages;
99
100 SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
101 accept_languages, "fr", &languages);
102
103 EXPECT_EQ(1U, languages.size());
104 EXPECT_EQ("fr", languages[0]);
105 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698