Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7591)

Unified Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed previous comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
index 7cbc67bb7ac92f50c66541ee1dff2d3e84dba1f7..6ec9b0b181492c331fe646aa5383b9baad67f049 100644
--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc
+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
@@ -28,78 +28,3 @@ class SpellcheckServiceTest : public testing::Test {
content::TestBrowserThreadBundle thread_bundle_;
TestingProfile profile_;
};
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {
please use gerrit instead 2015/06/06 01:42:13 Please port these tests to your new browser tests.
Julius 2015/06/12 20:10:15 Done.
- std::vector<std::string> accept_languages;
- accept_languages.push_back("en");
- accept_languages.push_back("en-US");
- std::vector<std::string> languages;
-
- SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
-
- EXPECT_EQ(1U, languages.size());
- EXPECT_EQ("en-US", languages[0]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
- std::vector<std::string> accept_languages;
- accept_languages.push_back("en-US");
- accept_languages.push_back("en");
- std::vector<std::string> languages;
-
- SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
-
- EXPECT_EQ(1U, languages.size());
- EXPECT_EQ("en-US", languages[0]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
- std::vector<std::string> accept_languages;
- accept_languages.push_back("en");
- accept_languages.push_back("en-US");
- accept_languages.push_back("en-AU");
- std::vector<std::string> languages;
-
- SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
-
- EXPECT_EQ(2U, languages.size());
-
- std::sort(languages.begin(), languages.end());
- EXPECT_EQ("en-AU", languages[0]);
- EXPECT_EQ("en-US", languages[1]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
- std::vector<std::string> accept_languages;
- accept_languages.push_back("en");
- accept_languages.push_back("en-US");
- accept_languages.push_back("fr");
- std::vector<std::string> languages;
-
- SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
-
- EXPECT_EQ(2U, languages.size());
-
- std::sort(languages.begin(), languages.end());
- EXPECT_EQ("en-US", languages[0]);
- EXPECT_EQ("fr", languages[1]);
-}
-
-TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
- std::vector<std::string> accept_languages;
- accept_languages.push_back("en");
- accept_languages.push_back("en-JP"); // Will not exist.
- accept_languages.push_back("fr");
- accept_languages.push_back("aa"); // Will not exist.
- std::vector<std::string> languages;
-
- SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "fr", &languages);
-
- EXPECT_EQ(1U, languages.size());
- EXPECT_EQ("fr", languages[0]);
-}

Powered by Google App Engine
This is Rietveld 408576698