Source/core/inspector/InspectorPageAgent.cpp - Issue 1156473002: Refactor FrameLoader loading interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 1156473002: Refactor FrameLoader loading interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed Nate's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorPageAgent.cpp

diff --git a/Source/core/inspector/InspectorPageAgent.cpp b/Source/core/inspector/InspectorPageAgent.cpp

index a50ed7a704e06f4ca117567a7bc01b25e92e5480..0ce2bdb473217c2018db058ecd191dd6fec18111 100644

--- a/Source/core/inspector/InspectorPageAgent.cpp

+++ b/Source/core/inspector/InspectorPageAgent.cpp

@@ -458,7 +458,7 @@ void InspectorPageAgent::reload(ErrorString*, const bool* const optionalIgnoreCa

ErrorString unused;

m_debuggerAgent->setSkipAllPauses(&unused, true);

m_reloading = true;

- inspectedFrame()->reload(asBool(optionalIgnoreCache) ? EndToEndReload : NormalReload, NotClientRedirect);

+ inspectedFrame()->reload(asBool(optionalIgnoreCache) ? FrameLoadTypeReloadFromOrigin : FrameLoadTypeReload, NotClientRedirect);

}

void InspectorPageAgent::navigate(ErrorString*, const String& url, String* outFrameId)