Source/core/frame/Frame.h - Issue 1156473002: Refactor FrameLoader loading interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Frame.h

Issue 1156473002: Refactor FrameLoader loading interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed Nate's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/Frame.h

diff --git a/Source/core/frame/Frame.h b/Source/core/frame/Frame.h

index bccaf64b1edd41d460a508173fbd9aa9b447ea3b..71c92285ef1add3c85af18ac209613e6c72451fc 100644

--- a/Source/core/frame/Frame.h

+++ b/Source/core/frame/Frame.h

@@ -30,6 +30,7 @@

#include "core/CoreExport.h"

#include "core/frame/FrameTypes.h"

+#include "core/loader/FrameLoaderTypes.h"

#include "core/page/FrameTree.h"

#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

@@ -69,7 +70,7 @@ public:

virtual WindowProxy* windowProxy(DOMWrapperWorld&) = 0;

virtual void navigate(Document& originDocument, const KURL&, bool lockBackForwardList, UserGestureStatus) = 0;

- virtual void reload(ReloadPolicy, ClientRedirectPolicy) = 0;

+ virtual void reload(FrameLoadType, ClientRedirectPolicy) = 0;

Nate Chapin 2015/06/05 18:16:30 if FrameLoadType is used here, it should probably

virtual void detach();

void detachChildren();

« no previous file with comments | « no previous file | Source/core/frame/FrameTypes.h » ('j') | no next file with comments »