Source/web/WebRemoteFrameImpl.h - Issue 1156473002: Refactor FrameLoader loading interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.h

Issue 1156473002: Refactor FrameLoader loading interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.h

diff --git a/Source/web/WebRemoteFrameImpl.h b/Source/web/WebRemoteFrameImpl.h

index 9381a09245211640152b4e6fd6c0ebb2d94d01df..1da97f325a165497800bd50fd33945d23989e956 100644

--- a/Source/web/WebRemoteFrameImpl.h

+++ b/Source/web/WebRemoteFrameImpl.h

@@ -78,7 +78,8 @@ public:

virtual v8::Local<v8::Context> mainWorldScriptContext() const override;

virtual void reload(bool ignoreCache) override;

virtual void reloadWithOverrideURL(const WebURL& overrideUrl, bool ignoreCache) override;

- virtual void loadRequest(const WebURLRequest&) override;

+ virtual void loadRequest(const WebURLRequest&, WebFrameLoadType, const WebHistoryItem&,

+ WebHistoryLoadType) override;

virtual void loadHistoryItem(const WebHistoryItem&, WebHistoryLoadType, WebURLRequest::CachePolicy) override;

virtual void loadData(

const WebData&, const WebString& mimeType, const WebString& textEncoding,