Source/web/WebRemoteFrameImpl.cpp - Issue 1156473002: Refactor FrameLoader loading interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 1156473002: Refactor FrameLoader loading interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index 64e9f01cbc4fbdd38bcc1d0a2f92e4da2161ba8f..f53125487d03010c5468a2d22ca7a2e94d5cb458 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -306,7 +306,8 @@ void WebRemoteFrameImpl::reloadWithOverrideURL(const WebURL& overrideUrl, bool i

ASSERT_NOT_REACHED();

}

-void WebRemoteFrameImpl::loadRequest(const WebURLRequest&)

+void WebRemoteFrameImpl::loadRequest(const WebURLRequest&, WebFrameLoadType, const WebHistoryItem&,

+ WebHistoryLoadType)

{

ASSERT_NOT_REACHED();

}