Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1156463002: Pass GC flags to incremental marker and start incremental marking with (Closed)

Created:
5 years, 7 months ago by ulan
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass GC flags to incremental marker and start incremental marking with reduce memory footprint in idle notification. BUG= Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc Cr-Commit-Position: refs/heads/master@{#28567}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/heap/heap.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ulan
PTAL
5 years, 7 months ago (2015-05-21 16:49:04 UTC) #2
Hannes Payer (out of office)
LGTM, just one renaming nit https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc#newcode470 src/heap/incremental-marking.cc:470: void IncrementalMarking::Start(int flags_for_mark_compact_collector) { ...
5 years, 7 months ago (2015-05-21 17:10:12 UTC) #3
ulan
thanks, landing https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/1156463002/diff/1/src/heap/incremental-marking.cc#newcode470 src/heap/incremental-marking.cc:470: void IncrementalMarking::Start(int flags_for_mark_compact_collector) { On 2015/05/21 17:10:12, ...
5 years, 7 months ago (2015-05-21 17:12:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156463002/40001
5 years, 7 months ago (2015-05-21 17:24:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 18:23:40 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc Cr-Commit-Position: refs/heads/master@{#28567}
5 years, 7 months ago (2015-05-21 18:23:52 UTC) #9
Michael Achenbach
5 years, 7 months ago (2015-05-21 20:34:19 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1151143002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert because chromebook is
really misbehaving:
http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109

I also triggered a retry with the failing build to be sure. If the revert
doesn't help or the bot had a scary hiccup, this can reland..

Powered by Google App Engine
This is Rietveld 408576698