Issue 1156383004: Add the floating action button to stocks2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156383004: Add the floating action button to stocks2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie, eseidel

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add the floating action button to stocks2 The + isn't quite centered properly, but the button is a circle in the right place. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f997e7c5e755248429d3cb155e838be70d0eab23

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -31 lines)			Patch
M	sky/engine/core/painting/Size.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_app.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/floating_action_button.dart	View	2 chunks	+13 lines, -22 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/radio.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/scaffold.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as f997e7c5e755248429d3cb155e838be70d0eab23 (presubmit successful).

5 years, 6 months ago (2015-06-05 17:07:55 UTC) #4

Message was sent while issue was closed.

lgtm