Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 1156363002: Add chrome_public_apk and chrome_public_test_apk targets in GN. (Closed)

Created:
5 years, 7 months ago by Yaron
Modified:
5 years, 6 months ago
Reviewers:
cjhopman, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome_public_apk and chrome_public_test_apk targets in GN. The new targets for mass-upstreaming were only added in Gyp. This brings parity to GN. BUG=484934 Committed: https://crrev.com/c1995be807fd95a833d93eef029a8642782b0d6e Cr-Commit-Position: refs/heads/master@{#332005}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ~ #

Patch Set 4 : rebase agagin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -5 lines) Patch
M BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 2 3 7 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Yaron
I tried defining a common template for this and the internal chrome_apk target but seemed ...
5 years, 7 months ago (2015-05-28 01:35:56 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-05-28 19:21:56 UTC) #3
Yaron
dpranke: BUILD.gn
5 years, 6 months ago (2015-05-28 20:15:16 UTC) #5
Dirk Pranke
lgtm
5 years, 6 months ago (2015-05-28 20:18:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156363002/20001
5 years, 6 months ago (2015-05-28 20:20:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/57229) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-05-28 20:25:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156363002/40001
5 years, 6 months ago (2015-05-29 14:42:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/63817)
5 years, 6 months ago (2015-05-29 15:44:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156363002/60001
5 years, 6 months ago (2015-05-29 16:00:29 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-05-29 17:52:34 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 17:54:39 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c1995be807fd95a833d93eef029a8642782b0d6e
Cr-Commit-Position: refs/heads/master@{#332005}

Powered by Google App Engine
This is Rietveld 408576698