Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: chrome/android/chrome_apk.gyp

Issue 1156363002: Add chrome_public_apk and chrome_public_test_apk targets in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase agagin Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/chrome_apk.gyp
diff --git a/chrome/android/chrome_apk.gyp b/chrome/android/chrome_apk.gyp
index 72497842db6ed602f4e475ee60ece94a4af62600..6d319177cfbdcfe7eb58ded27598c4cc0735e7a6 100644
--- a/chrome/android/chrome_apk.gyp
+++ b/chrome/android/chrome_apk.gyp
@@ -191,6 +191,7 @@
'includes': [ '../../build/java.gypi' ],
},
{
+ # GN: //chrome/android:chrome_template_resources
'target_name': 'chrome_template_resources',
'type': 'none',
'variables': {
@@ -213,6 +214,7 @@
'includes': [ '../../build/android/jinja_template.gypi' ],
},
{
+ # GN: //chrome/android:hosted_service_aidl
'target_name': 'hosted_service_aidl',
'type': 'none',
'variables': {
@@ -226,7 +228,7 @@
'includes': [ '../../build/java_aidl.gypi' ],
},
{
- # GN: TODO
+ # GN: //chrome/android:chrome_public
'target_name': 'libchrome_public',
'type': 'shared_library',
'dependencies': [
@@ -269,6 +271,7 @@
],
},
{
+ # GN: //chrome/android:chrome_public_apk_manifest
'target_name': 'chrome_public_manifest',
'type': 'none',
'variables': {
@@ -284,6 +287,7 @@
'includes': [ '../../build/android/jinja_template.gypi' ],
},
{
+ # GN: //chrome/android:chrome_public_apk
'target_name': 'chrome_public_apk',
'type': 'none',
'variables': {
@@ -369,8 +373,7 @@
'includes': [ '../../build/java.gypi' ],
},
{
- # GN: None. This will most likely be merged with chrome_shell before GN is
- # done.
+ # GN: //chrome/android:chrome_public_test_apk_manifest
'target_name': 'chrome_public_test_apk_manifest',
'type': 'none',
'variables': {
@@ -383,8 +386,7 @@
'includes': [ '../../build/android/jinja_template.gypi' ],
},
{
- # GN: None. This will most likely be merged with chrome_shell before GN is
- # done.
+ # GN: //chrome/android:chrome_public_test_apk
'target_name': 'chrome_public_test_apk',
'type': 'none',
'dependencies': [
« no previous file with comments | « chrome/android/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698