Add AlphaThreshold filter.

src/effects/SkAlphaThresholdFilter.cpp

Index: src/effects/SkAlphaThresholdFilter.cpp
diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..a1c893621fd6804f4d881bede846427ec03ba038
--- /dev/null
+++ b/src/effects/SkAlphaThresholdFilter.cpp
@@ -0,0 +1,286 @@
+/*
+ * Copyright 2013 The Android Open Source Project
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "SkAlphaThresholdFilter.h"
+#include "SkBitmap.h"
+#include "SkFlattenableBuffers.h"
+#include "SkRegion.h"
+
+#if SK_SUPPORT_GPU
+#include "GrContext.h"
+#include "GrCoordTransform.h"
+#include "GrEffect.h"
+#include "gl/GrGLEffect.h"
+#include "GrTBackendEffectFactory.h"
+#include "GrTextureAccess.h"
+
+#include "SkGr.h"
+
+class GrGLAlphaThresholdEffect;
+
+class AlphaThresholdEffect : public GrEffect {
+
+public:
+    static GrEffectRef* Create(GrTexture* texture,
+                               GrTexture* maskTexture,
+                               float innerThreshold,
+                               float outerThreshold) {
+        AutoEffectUnref effect(SkNEW_ARGS(AlphaThresholdEffect, (texture,
+                                                                 maskTexture,
+                                                                 innerThreshold,
+                                                                 outerThreshold)));
+        return CreateEffectRef(effect);
+    }
+
+    virtual ~AlphaThresholdEffect() {};
+
+    static const char* Name() { return "Alpha Threshold"; }
+
+    virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE;
+    virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
+
+    float innerThreshold() const { return fInnerThreshold; }
+    float outerThreshold() const { return fOuterThreshold; }
+
+    typedef GrGLAlphaThresholdEffect GLEffect;
+
+private:
+    AlphaThresholdEffect(GrTexture* texture,
+                         GrTexture* maskTexture,
+                         float innerThreshold,
+                         float outerThreshold)
+        : fInnerThreshold(innerThreshold)
+        , fOuterThreshold(outerThreshold)
+        , fImageCoordTransform(kLocal_GrCoordSet, MakeDivByTextureWHMatrix(texture), texture)
+        , fImageTextureAccess(texture)
+        , fMaskCoordTransform(kLocal_GrCoordSet, MakeDivByTextureWHMatrix(maskTexture), maskTexture)
+        , fMaskTextureAccess(maskTexture) {
+        this->addCoordTransform(&fImageCoordTransform);
+        this->addTextureAccess(&fImageTextureAccess);
+        this->addCoordTransform(&fMaskCoordTransform);
+        this->addTextureAccess(&fMaskTextureAccess);
+    }
+
+    virtual bool onIsEqual(const GrEffect&) const SK_OVERRIDE;
+
+    GR_DECLARE_EFFECT_TEST;
+
+    float fInnerThreshold;
+    float fOuterThreshold;
+    GrCoordTransform fImageCoordTransform;
+    GrTextureAccess  fImageTextureAccess;
+    GrCoordTransform fMaskCoordTransform;
+    GrTextureAccess  fMaskTextureAccess;
+
+    typedef GrEffect INHERITED;
+};
+
+// For brevity
+typedef GrGLUniformManager::UniformHandle UniformHandle;

[Wez, 2013/12/17 06:39:04]

nit: Why not just using GrGL...::UniformHandle?

[Zachary Kuznia, 2013/12/18 00:06:27]

Done.

+
+class GrGLAlphaThresholdEffect : public GrGLEffect {
+public:
+    GrGLAlphaThresholdEffect(const GrBackendEffectFactory&, const GrDrawEffect&);
+
+    virtual void emitCode(GrGLShaderBuilder*,
+                          const GrDrawEffect&,
+                          EffectKey,
+                          const char* outputColor,
+                          const char* inputColor,
+                          const TransformedCoordsArray&,
+                          const TextureSamplerArray&) SK_OVERRIDE;
+
+    virtual void setData(const GrGLUniformManager&, const GrDrawEffect&) SK_OVERRIDE;
+
+private:
+    UniformHandle       fInnerThresholdVar;
+    UniformHandle       fOuterThresholdVar;
+
+    typedef GrGLEffect INHERITED;
+};
+
+GrGLAlphaThresholdEffect::GrGLAlphaThresholdEffect(const GrBackendEffectFactory& factory, const GrDrawEffect&)
+    : INHERITED(factory) {
+}
+
+void GrGLAlphaThresholdEffect::emitCode(GrGLShaderBuilder* builder,
+                                   const GrDrawEffect&,
+                                   EffectKey key,
+                                   const char* outputColor,
+                                   const char* inputColor,
+                                   const TransformedCoordsArray& coords,
+                                   const TextureSamplerArray& samplers) {
+    SkString coords2D = builder->ensureFSCoords2D(coords, 0);
+    SkString maskCoords2D = builder->ensureFSCoords2D(coords, 1);
+    fInnerThresholdVar = builder->addUniform(
+        GrGLShaderBuilder::kFragment_Visibility,
+        kFloat_GrSLType, "inner_threshold");
+    fOuterThresholdVar = builder->addUniform(
+        GrGLShaderBuilder::kFragment_Visibility,
+        kFloat_GrSLType, "outer_threshold");
+
+    builder->fsCodeAppendf("\t\tvec2 coord = %s;\n", coords2D.c_str());
+    builder->fsCodeAppendf("\t\tvec2 mask_coord = %s;\n", maskCoords2D.c_str());
+    builder->fsCodeAppend("\t\tvec4 color = ");
+    builder->fsAppendTextureLookup(samplers[0], "coord");
+    builder->fsCodeAppend(";\n");
+    builder->fsCodeAppend("\t\tvec4 mask_color = ");
+    builder->fsAppendTextureLookup(samplers[1], "mask_coord");
+    builder->fsCodeAppend(";\n");
+
+    builder->fsCodeAppendf("\t\tfloat inner_thresh = %s;\n",
+                           builder->getUniformCStr(fInnerThresholdVar));
+    builder->fsCodeAppendf("\t\tfloat outer_thresh = %s;\n",
+                           builder->getUniformCStr(fOuterThresholdVar));
+    builder->fsCodeAppend("\t\tfloat mask = mask_color.a;\n");
+
+    builder->fsCodeAppend("\t\tif (mask < 0.5) {\n"
+                          "\t\t\tif (color.a > outer_thresh) {\n"
+                          "\t\t\t\tfloat scale = outer_thresh / color.a;\n"
+                          "\t\t\t\tcolor.rgb *= scale;\n"
+                          "\t\t\t\tcolor.a = outer_thresh;\n"
+                          "\t\t\t}\n"
+                          "\t\t} else if (color.a < inner_thresh) {\n"
+                          "\t\t\tfloat scale = inner_thresh / color.a;\n"
+                          "\t\t\tcolor.rgb *= scale;\n"
+                          "\t\t\tcolor.a = inner_thresh;\n"
+                          "\t\t}\n");
+
+    builder->fsCodeAppendf("%s = %s;\n", outputColor,
+                           (GrGLSLExpr4(inputColor) * GrGLSLExpr4("color")).c_str());
+}
+
+void GrGLAlphaThresholdEffect::setData(const GrGLUniformManager& uman,
+                                  const GrDrawEffect& drawEffect) {
+    const AlphaThresholdEffect& alpha_threshold =
+        drawEffect.castEffect<AlphaThresholdEffect>();
+    uman.set1f(fInnerThresholdVar, alpha_threshold.innerThreshold());
+    uman.set1f(fOuterThresholdVar, alpha_threshold.outerThreshold());
+}
+
+/////////////////////////////////////////////////////////////////////
+
+GR_DEFINE_EFFECT_TEST(AlphaThresholdEffect);
+
+GrEffectRef* AlphaThresholdEffect::TestCreate(SkRandom* random,
+                                              GrContext* context,
+                                              const GrDrawTargetCaps&,
+                                              GrTexture** textures) {
+    GrTexture* bmpTex = textures[GrEffectUnitTest::kSkiaPMTextureIdx];
+    GrTexture* maskTex = textures[GrEffectUnitTest::kAlphaTextureIdx];
+    U8CPU inner_thresh = random->nextU() % 0xff;
+    U8CPU outer_thresh = random->nextU() % 0xff;
+    return AlphaThresholdEffect::Create(bmpTex, maskTex, inner_thresh, outer_thresh);
+}
+
+///////////////////////////////////////////////////////////////////////////////
+
+const GrBackendEffectFactory& AlphaThresholdEffect::getFactory() const {
+    return GrTBackendEffectFactory<AlphaThresholdEffect>::getInstance();
+}
+
+bool AlphaThresholdEffect::onIsEqual(const GrEffect& sBase) const {
+    const AlphaThresholdEffect& s = CastEffect<AlphaThresholdEffect>(sBase);
+    return (this->texture(0) == s.texture(0) &&
+            this->fInnerThreshold == s.fInnerThreshold &&
+            this->fOuterThreshold == s.fOuterThreshold);
+}
+
+void AlphaThresholdEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {
+    if ((*validFlags & kA_GrColorComponentFlag) && 0xFF == GrColorUnpackA(*color) &&
+        GrPixelConfigIsOpaque(this->texture(0)->config())) {
+        *validFlags = kA_GrColorComponentFlag;
+    } else {
+        *validFlags = 0;
+    }
+}
+
+#endif
+
+SkAlphaThresholdFilter::SkAlphaThresholdFilter(SkFlattenableReadBuffer& buffer)
+  : INHERITED(1, buffer) {
+    fInnerThreshold = buffer.readScalar();
+    fOuterThreshold = buffer.readScalar();
+    buffer.readRegion(&fRegion);
+}
+
+SkAlphaThresholdFilter::SkAlphaThresholdFilter(SkRegion region, SkScalar innerThreshold, SkScalar outerThreshold)
+    : INHERITED(0), fRegion(region), fInnerThreshold(innerThreshold), fOuterThreshold(outerThreshold) {
+}
+
+#if SK_SUPPORT_GPU
+bool SkAlphaThresholdFilter::asNewEffect(GrEffectRef** effect, GrTexture* texture, const SkMatrix& in_matrix, const SkIRect&) const {
+    if (effect) {
+        GrContext* context = texture->getContext();
+        GrTextureDesc maskDesc;
+        if (context->isConfigRenderable(kAlpha_8_GrPixelConfig, false)) {
+            maskDesc.fConfig = kAlpha_8_GrPixelConfig;
+        } else {
+            maskDesc.fConfig = kRGBA_8888_GrPixelConfig;
+        }
+        maskDesc.fFlags = kRenderTarget_GrTextureFlagBit | kNoStencil_GrTextureFlagBit;
+        // Add one pixel of border to ensure that clamp mode will be all zeros
+        // the outside.
+        maskDesc.fWidth = texture->width();
+        maskDesc.fHeight = texture->height();
+        GrAutoScratchTexture ast(context, maskDesc, GrContext::kApprox_ScratchTexMatch);
+        GrTexture*  maskTexture = ast.texture();
+        if (NULL == maskTexture) {
+            return false;
+        }
+
+        {
+            GrContext::AutoRenderTarget art(context, ast.texture()->asRenderTarget());
+            GrPaint grPaint;
+            grPaint.setBlendFunc(kOne_GrBlendCoeff, kZero_GrBlendCoeff);
+            SkRegion::Iterator iter(fRegion);
+            context->clear(NULL, 0x0, true);
+
+            SkMatrix old_matrix = context->getMatrix();
+            context->setMatrix(in_matrix);
+
+            while (!iter.done()) {
+                SkRect rect = SkRect::Make(iter.rect());
+                context->drawRect(grPaint, rect);
+                iter.next();
+            }
+            context->setMatrix(old_matrix);
+      }
+
+      *effect = AlphaThresholdEffect::Create(texture,
+                                             maskTexture,
+                                             fInnerThreshold,
+                                             fOuterThreshold);
+    }
+    return true;
+}
+#endif
+
+void SkAlphaThresholdFilter::flatten(SkFlattenableWriteBuffer& buffer) const {
+    this->INHERITED::flatten(buffer);
+    buffer.writeScalar(fInnerThreshold);
+    buffer.writeScalar(fOuterThreshold);
+    buffer.writeRegion(fRegion);
+}
+
+bool SkAlphaThresholdFilter::onFilterImage(Proxy*, const SkBitmap& src,
+                                           const SkMatrix&, SkBitmap* dst,
+                                           SkIPoint* offset) {
+    SkASSERT(src.config() == SkBitmap::kARGB_8888_Config);
+
+    if (src.config() != SkBitmap::kARGB_8888_Config) {
+      return false;
+    }
+
+    SkAutoLockPixels alp(src);
+    SkASSERT(src.getPixels());
+    if (!src.getPixels() || src.width() <= 0 || src.height() <= 0) {
+      return false;
+    }
+
+    return true;

[reed1, 2013/12/16 14:30:49]

Why do we return true, but don't set dst? Can we write a CPU implementation, so
we have something to compare the GPU version with? 

[Zachary Kuznia, 2013/12/18 00:06:27]

Software version added.

+}