Issue 1156203003: Fix dart:sky.internals to work in SkyView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156203003: Fix dart:sky.internals to work in SkyView (Closed)

Created:
5 years, 7 months ago by eseidel

Modified:
5 years, 7 months ago

Reviewers:
abarth-chromium, Hixie

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix dart:sky.internals to work in SkyView R=ianh@google.com TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d1116c964b8458b81371e79ec68ffdf1e55a4b67

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -0 lines)			Patch
M	sky/engine/public/sky/sky_view.cc	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	sky/engine/public/sky/sky_view_client.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/viewer/document_view.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

Committed patchset #1 (id:1) manually as d1116c964b8458b81371e79ec68ffdf1e55a4b67 (presubmit successful).

5 years, 7 months ago (2015-05-26 23:01:30 UTC) #4

abarth-chromium

5 years, 7 months ago (2015-05-27 02:19:03 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1156203003/diff/1/sky/engine/public/sky/sky_v...
File sky/engine/public/sky/sky_view.cc (right):

https://codereview.chromium.org/1156203003/diff/1/sky/engine/public/sky/sky_v...
sky/engine/public/sky/sky_view.cc:64: }
I probably would have moved this to a new (private) function on SkyView to avoid
the ugly { } indenting.  :)

Expand Messages | Collapse Messages