Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: sky/engine/public/sky/sky_view.cc

Issue 1156203003: Fix dart:sky.internals to work in SkyView (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/public/sky/sky_view_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/public/sky/sky_view.cc
diff --git a/sky/engine/public/sky/sky_view.cc b/sky/engine/public/sky/sky_view.cc
index 45edf46a2737ae170f96551a30a07ea01a624c3a..a17c520a6f54d681ca108484d5516a3d1dfed7a9 100644
--- a/sky/engine/public/sky/sky_view.cc
+++ b/sky/engine/public/sky/sky_view.cc
@@ -55,6 +55,14 @@ void SkyView::Load(const WebURL& url, mojo::URLResponsePtr response) {
dart_controller_.reset(new DartController);
dart_controller_->CreateIsolateFor(adoptPtr(new DOMDartState(nullptr)), url);
dart_controller_->InstallView(data_->view_.get());
+
+ {
+ Dart_Isolate isolate = dart_controller_->dart_state()->isolate();
+ DartIsolateScope scope(isolate);
+ DartApiScope api_scope;
+ client_->DidCreateIsolate(isolate);
+ }
abarth-chromium 2015/05/27 02:19:03 I probably would have moved this to a new (private
+
dart_controller_->LoadMainLibrary(url, response.Pass());
}
« no previous file with comments | « no previous file | sky/engine/public/sky/sky_view_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698