Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2294)

Unified Diff: base/files/memory_mapped_file.cc

Issue 1156183003: Pass file Regions along with FDs to child processes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change default values for Region to -1, -1 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/memory_mapped_file.cc
diff --git a/base/files/memory_mapped_file.cc b/base/files/memory_mapped_file.cc
index 891fcffc4cb434b74729657b7981a400729f2e61..cfb19d21232d0a35b93254b1b44cdf981e2ec3bb 100644
--- a/base/files/memory_mapped_file.cc
+++ b/base/files/memory_mapped_file.cc
@@ -16,10 +16,11 @@ const MemoryMappedFile::Region MemoryMappedFile::Region::kWholeFile(
MemoryMappedFile::Region::Region(base::LinkerInitialized) : offset(0), size(0) {
}
+MemoryMappedFile::Region::Region() : offset(-1), size(-1) {
+}
Primiano Tucci (use gerrit) 2015/05/29 10:44:34 Not sure I get what is the use case for the empty
agrieve 2015/05/29 19:16:39 There's two parts to this: 1. Why have a default c
Primiano Tucci (use gerrit) 2015/06/01 09:14:53 Oh, I see the point, makes sense.
+
MemoryMappedFile::Region::Region(int64 offset, int64 size)
: offset(offset), size(size) {
- DCHECK_GE(offset, 0);
- DCHECK_GT(size, 0);
}
bool MemoryMappedFile::Region::operator==(

Powered by Google App Engine
This is Rietveld 408576698