Pass file Regions along with FDs to child processes on Android

base/files/memory_mapped_file.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/memory_mapped_file.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/sys_info.h"
 
 namespace base {
 
 const MemoryMappedFile::Region MemoryMappedFile::Region::kWholeFile(
     base::LINKER_INITIALIZED);
 
 MemoryMappedFile::Region::Region(base::LinkerInitialized) : offset(0), size(0) {
 }
 
+MemoryMappedFile::Region::Region() : offset(-1), size(-1) {
+}

[Primiano Tucci (use gerrit), 2015/05/29 10:44:34]

Not sure I get what is the use case for the empty ctor here. Is it different
from kWholeFile? Why kWholeFile is (0,0) and the default ctor is (-1,-1).
If this is just to get this into a map, isn't just a matter of having explicit
copy and assignment ctors?

[agrieve, 2015/05/29 19:16:39]

There's two parts to this:
1. Why have a default constructor at all?
- I think we could continue to get away without one, but since this is a struct
that is now being used as an out parameter, it's quite annoying for it to not
have a default constructor. Unless there's a compelling reason to not have one,
I think it should.

2. What should the default values be:
-There's two decent options here: kWholeFile, or -1, -1 (invalid values). 
-I think either are reasonable, and I don't see a strong case for one over the
other (although I do slightly favour invalid values).

[Primiano Tucci (use gerrit), 2015/06/01 09:14:53]

Oh, I see the point, makes sense.
SGTM.

+
 MemoryMappedFile::Region::Region(int64 offset, int64 size)
     : offset(offset), size(size) {
-  DCHECK_GE(offset, 0);
-  DCHECK_GT(size, 0);
 }
 
 bool MemoryMappedFile::Region::operator==(
     const MemoryMappedFile::Region& other) const {
   return other.offset == offset && other.size == size;
 }
 
 MemoryMappedFile::~MemoryMappedFile() {
   CloseHandles();
 }
@@ skipping 49 matching lines @@
   // Sadly, on Windows, the mmap alignment is not just equal to the page size.
   const int64 mask = static_cast<int64>(SysInfo::VMAllocationGranularity()) - 1;
   DCHECK_LT(mask, std::numeric_limits<int32>::max());
   *offset = start & mask;
   *aligned_start = start & ~mask;
   *aligned_size = (size + *offset + mask) & ~mask;
 }
 #endif
 
 }  // namespace base