Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: tools/testrunner/local/execution.py

Issue 1156133006: [test] Verbose test runner output on windows. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: presubmit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/run-tests.py ('k') | tools/testrunner/local/progress.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py
index 35e0efe7cfed032be4601bae3f9efcdf2b5d8755..e13393bf1c7626f1d64a48ab627e1f8dec1679aa 100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -28,6 +28,7 @@
import os
import shutil
+import sys
import time
from pool import Pool
@@ -150,6 +151,7 @@ class Runner(object):
self.indicator.HasRun(test, has_unexpected_output or test.run > 1)
if has_unexpected_output:
# Rerun test failures after the indicator has processed the results.
+ self._VerbosePrint("Attempting to rerun test after failure.")
self._MaybeRerun(pool, test)
# Update the perf database if the test succeeded.
return not has_unexpected_output
@@ -241,7 +243,9 @@ class Runner(object):
if update_perf:
self._RunPerfSafe(lambda: self.perfdata.UpdatePerfData(test))
finally:
+ self._VerbosePrint("Closing process pool.")
pool.terminate()
+ self._VerbosePrint("Closing database connection.")
self._RunPerfSafe(lambda: self.perf_data_manager.close())
if self.perf_failures:
# Nuke perf data in case of failures. This might not work on windows as
@@ -254,6 +258,11 @@ class Runner(object):
# Make sure that any allocations were printed in predictable mode.
assert not self.context.predictable or self.printed_allocations
+ def _VerbosePrint(self, text):
+ if self.context.verbose:
+ print text
+ sys.stdout.flush()
+
def GetCommand(self, test):
d8testflag = []
shell = test.suite.shell()
« no previous file with comments | « tools/run-tests.py ('k') | tools/testrunner/local/progress.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698