Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: tools/run-tests.py

Issue 1156133006: [test] Verbose test runner output on windows. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: presubmit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testrunner/local/execution.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index 274bb18ac62227573d98ab705eaacb805705cd36..e8a9598491ccbc6f392609fda84fe0ff9d155163 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -540,8 +540,14 @@ def Execute(arch, mode, args, options, suites, workspace):
# Predictable mode is slower.
timeout *= 2
+ # TODO(machenbach): Remove temporary verbose output on windows after
+ # debugging driver-hung-up on XP.
+ verbose_output = (
+ options.verbose or
+ utils.IsWindows() and options.progress == "verbose"
+ )
ctx = context.Context(arch, MODES[mode]["execution_mode"], shell_dir,
- mode_flags, options.verbose,
+ mode_flags, verbose_output,
timeout, options.isolates,
options.command_prefix,
options.extra_flags,
« no previous file with comments | « no previous file | tools/testrunner/local/execution.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698