Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1156113007: Add WebRuntimeFeatures::enablePermissionsAPI. (Closed)

Created:
5 years, 7 months ago by timvolodine
Modified:
5 years, 7 months ago
Reviewers:
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/branch-heads/chromium/2357
Project:
blink
Visibility:
Public.

Description

Add WebRuntimeFeatures::enablePermissionsAPI. Add the ability to control whether we want to expose the Permissions API in blink at runtime. This is e.g. needed for WebView where the Permissions API is currently not supported. BUG=489926 TBR=dglazkov NOTRY=true Review URL: https://codereview.chromium.org/1150653002 git-svn-id: svn://svn.chromium.org/blink/trunk@195691 bbb929c8-8fbe-4397-9dbb-9b2b20218538 (cherry picked from commit 867b90077485d07fc4dc60de24112bdad2085e6a) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156113007/1
5 years, 7 months ago (2015-05-27 17:37:29 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/36509)
5 years, 7 months ago (2015-05-27 17:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156113007/1
5 years, 7 months ago (2015-05-27 17:59:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195998
5 years, 7 months ago (2015-05-27 18:04:21 UTC) #7
Noel Gordon
Tim, trys all turing red after this patch. Expected?
5 years, 7 months ago (2015-05-27 18:32:28 UTC) #8
timvolodine
On 2015/05/27 18:32:28, noel gordon wrote: > Tim, trys all turing red after this patch. ...
5 years, 7 months ago (2015-05-27 18:35:01 UTC) #9
samuong
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1157773005/ by samuong@chromium.org. ...
5 years, 7 months ago (2015-05-27 18:35:10 UTC) #10
timvolodine
5 years, 7 months ago (2015-05-27 18:42:27 UTC) #11
Message was sent while issue was closed.
On 2015/05/27 18:35:10, samuong wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1157773005/ by mailto:samuong@chromium.org.
> 
> The reason for reverting is: This change has been applied twice, and is
causing
> compile failures on the following bots (and probably more):
> 
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/b...
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%2...
> http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/32401
> 
> Was this supposed to land on a different branch?.

oops yes sorry something went wrong, the base url is wrong this was meant for
M43 (2357)

Powered by Google App Engine
This is Rietveld 408576698