content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java - Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

index f2e0262514d3bf02fb0284be0eb83f76cf446feb..36e574a06cf63f279029dfce0fe1ccca55fc8a4b 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

@@ -59,8 +59,9 @@ public class TestWebContentsObserver extends WebContentsObserver {

@Override

public void didFailLoad(boolean isProvisionalLoad, boolean isMainFrame,

- int errorCode, String description, String failingUrl) {

- super.didFailLoad(isProvisionalLoad, isMainFrame, errorCode, description, failingUrl);

+ int errorCode, String description, String failingUrl, boolean wasIgnoredByHandler) {

+ super.didFailLoad(isProvisionalLoad, isMainFrame, errorCode, description, failingUrl,

+ wasIgnoredByHandler);

mOnReceivedErrorHelper.notifyCalled(errorCode, description, failingUrl);

}

« content/child/web_url_request_util.cc ('K') | « content/public/browser/web_contents_observer.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »