content/public/browser/web_contents_observer.h - Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_request_util.cc ('K') | « content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_observer.h

diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h

index b040d64223fe81a143daaedff660bad609e10dd2..bc5a942e0932bd40e1d6f8921c0958662cc9821b 100644

--- a/content/public/browser/web_contents_observer.h

+++ b/content/public/browser/web_contents_observer.h

@@ -161,7 +161,8 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,

RenderFrameHost* render_frame_host,

const GURL& validated_url,

int error_code,

- const base::string16& error_description) {}

+ const base::string16& error_description,

+ bool was_ignored_by_handler) {}

// If the provisional load corresponded to the main frame, this method is

// invoked in addition to DidCommitProvisionalLoadForFrame.

@@ -203,7 +204,8 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,

virtual void DidFailLoad(RenderFrameHost* render_frame_host,

const GURL& validated_url,

int error_code,

- const base::string16& error_description) {}

+ const base::string16& error_description,

+ bool was_ignored_by_handler) {}

// This method is invoked when content was loaded from an in-memory cache.

virtual void DidLoadResourceFromMemoryCache(