Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: content/child/web_url_request_util.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_url_request_util.cc
diff --git a/content/child/web_url_request_util.cc b/content/child/web_url_request_util.cc
index 6737307c744b5af3a2d255c3d3a82234da880c55..19d7b5af7fcc7285a43d905be2b9e9b648e3fa11 100644
--- a/content/child/web_url_request_util.cc
+++ b/content/child/web_url_request_util.cc
@@ -299,4 +299,14 @@ blink::WebURLError CreateWebURLError(const blink::WebURL& unreachable_url,
return error;
}
+blink::WebURLError CreateWebURLError(const blink::WebURL& unreachable_url,
+ bool stale_copy_in_cache,
+ int reason,
+ bool was_ignored_by_handler) {
+ blink::WebURLError error =
+ CreateWebURLError(unreachable_url, stale_copy_in_cache, reason);
+ error.wasIgnoredByHandler = was_ignored_by_handler;
sgurun-gerrit only 2015/06/04 06:37:34 maybe this can be a melded into "reason"?
gsennton 2015/06/04 14:55:19 That might be easier. I thought such a change migh
mnaganov (inactive) 2015/06/04 19:09:27 A possible alternative is to avoid routing this fl
gsennton 2015/06/08 14:07:23 I think we would still have the same problem here
+ return error;
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698