Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: content/child/web_url_request_util.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_request_util.h" 5 #include "content/child/web_url_request_util.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "net/base/load_flags.h" 9 #include "net/base/load_flags.h"
10 #include "net/base/net_errors.h" 10 #include "net/base/net_errors.h"
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 } else if (reason == net::ERR_TEMPORARILY_THROTTLED) { 292 } else if (reason == net::ERR_TEMPORARILY_THROTTLED) {
293 error.localizedDescription = 293 error.localizedDescription =
294 WebString::fromUTF8(kThrottledErrorDescription); 294 WebString::fromUTF8(kThrottledErrorDescription);
295 } else { 295 } else {
296 error.localizedDescription = 296 error.localizedDescription =
297 WebString::fromUTF8(net::ErrorToString(reason)); 297 WebString::fromUTF8(net::ErrorToString(reason));
298 } 298 }
299 return error; 299 return error;
300 } 300 }
301 301
302 blink::WebURLError CreateWebURLError(const blink::WebURL& unreachable_url,
303 bool stale_copy_in_cache,
304 int reason,
305 bool was_ignored_by_handler) {
306 blink::WebURLError error =
307 CreateWebURLError(unreachable_url, stale_copy_in_cache, reason);
308 error.wasIgnoredByHandler = was_ignored_by_handler;
sgurun-gerrit only 2015/06/04 06:37:34 maybe this can be a melded into "reason"?
gsennton 2015/06/04 14:55:19 That might be easier. I thought such a change migh
mnaganov (inactive) 2015/06/04 19:09:27 A possible alternative is to avoid routing this fl
gsennton 2015/06/08 14:07:23 I think we would still have the same problem here
309 return error;
310 }
311
302 } // namespace content 312 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698