content/child/web_url_loader_impl.cc - Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_url_loader_impl.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/renderer/aw_content_renderer_client.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/child/web_url_request_util.h » ('j') | content/child/web_url_request_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/web_url_loader_impl.cc

diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc

index 818f5d525e30c74f81981a653c312092eb9e94dd..7f6eecede0606abca9360dba8982f93f6fa095a3 100644

--- a/content/child/web_url_loader_impl.cc

+++ b/content/child/web_url_loader_impl.cc

@@ -742,7 +742,8 @@ void WebURLLoaderImpl::Context::OnCompletedRequest(

if (error_code != net::OK) {

client_->didFail(

loader_,

- CreateWebURLError(request_.url(), stale_copy_in_cache, error_code));

+ CreateWebURLError(request_.url(), stale_copy_in_cache, error_code,

+ was_ignored_by_handler));

} else {

if (request_.useStreamOnResponse()) {

got_all_stream_body_data_ = true;