Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 2a8a92c6b93fc5ff7299201af9e88d660da46596..3242e47bd80a365e5452a3557c598d023566b0fc 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2595,7 +2595,8 @@ void WebContentsImpl::DidFailProvisionalLoadWithError(
DidFailProvisionalLoad(render_frame_host,
validated_url,
params.error_code,
- params.error_description));
+ params.error_description,
+ params.was_ignored_by_handler));
FrameTreeNode* ftn = render_frame_host->frame_tree_node();
BrowserAccessibilityManager* manager =
@@ -2608,11 +2609,13 @@ void WebContentsImpl::DidFailLoadWithError(
RenderFrameHostImpl* render_frame_host,
const GURL& url,
int error_code,
- const base::string16& error_description) {
+ const base::string16& error_description,
+ bool was_ignored_by_handler) {
FOR_EACH_OBSERVER(
WebContentsObserver,
observers_,
- DidFailLoad(render_frame_host, url, error_code, error_description));
+ DidFailLoad(render_frame_host, url, error_code, error_description,
+ was_ignored_by_handler));
}
void WebContentsImpl::NotifyChangedNavigationState(

Powered by Google App Engine
This is Rietveld 408576698