Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 11557009: Remove support for TRACE_EVENT_IF_LONGER_THANx macros (Closed)

Created:
8 years ago by caseq
Modified:
8 years ago
CC:
chromium-reviews, erikwright+watch_chromium.org, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Remove support for TRACE_EVENT_IF_LONGER_THANx macros These add consederable amount of complexity, yet only have 1 (one) usage. BUG=none TEST=base_unittest TBR=gman,darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172863

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -273 lines) Patch
M base/debug/trace_event.h View 9 chunks +11 lines, -90 lines 0 comments Download
M base/debug/trace_event.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M base/debug/trace_event_impl.h View 2 chunks +1 line, -8 lines 0 comments Download
M base/debug/trace_event_impl.cc View 5 chunks +3 lines, -26 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 3 chunks +0 lines, -119 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.cc View 1 chunk +1 line, -1 line 1 comment Download
M webkit/glue/webkitplatformsupport_impl.h View 2 chunks +12 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +20 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
caseq1
8 years ago (2012-12-12 09:26:12 UTC) #1
nduca
lgtm, thank you! https://codereview.chromium.org/11557009/diff/1/gpu/command_buffer/client/cmd_buffer_helper.cc File gpu/command_buffer/client/cmd_buffer_helper.cc (right): https://codereview.chromium.org/11557009/diff/1/gpu/command_buffer/client/cmd_buffer_helper.cc#newcode180 gpu/command_buffer/client/cmd_buffer_helper.cc:180: TRACE_EVENT0("gpu", "CommandBufferHelper::WaitForToken"); Lets just take this ...
8 years ago (2012-12-12 09:31:15 UTC) #2
nduca
(I assume you'll yank this from WebKit's side too, or just yank all of webkit's ...
8 years ago (2012-12-12 09:33:33 UTC) #3
nduca
I'd suggest @jam for base/ owners and @gman for gpu
8 years ago (2012-12-12 09:58:03 UTC) #4
caseq1
8 years ago (2012-12-12 10:01:33 UTC) #5
jam
On 2012/12/12 09:58:03, nduca wrote: > I'd suggest @jam for base/ owners and @gman for ...
8 years ago (2012-12-12 18:11:21 UTC) #6
caseq1
8 years ago (2012-12-12 18:38:04 UTC) #7
nduca
aw, darn, @jar not @jam. I'm incompetent.
8 years ago (2012-12-12 19:03:05 UTC) #8
jar (doing other things)
predominantly a rubber stamp LGTM for base (I looked at code... it seemed reasonable... but ...
8 years ago (2012-12-12 22:50:51 UTC) #9
brettw
8 years ago (2012-12-13 21:55:31 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698