Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1155683010: Revert of Only record one in n line endings to save space. (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
Erik Corry, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Only record one in n line endings to save space. (patchset #4 id:60001 of https://codereview.chromium.org/1137683003/) Reason for revert: Test failures https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/345/layout-test-results/results.html Original issue's description: > Only record one in n line endings to save space. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/b3d4bce593559276e68d3d7d9168f4351e4e5090 > Cr-Commit-Position: refs/heads/master@{#28837} TBR=yangguo@chromium.org,erik.corry@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/dc6907b3ed191bd6b90978ba9572cc7e4f951798 Cr-Commit-Position: refs/heads/master@{#28841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -377 lines) Patch
M src/debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/macros.py View 1 chunk +0 lines, -7 lines 0 comments Download
M src/messages.js View 9 chunks +41 lines, -100 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 3 chunks +36 lines, -170 lines 0 comments Download
M src/rewriter.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +44 lines, -81 lines 0 comments Download
M test/mjsunit/debug-sourceinfo.js View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry Chromium.org
Created Revert of Only record one in n line endings to save space.
5 years, 6 months ago (2015-06-08 14:24:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155683010/1
5 years, 6 months ago (2015-06-08 14:24:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 14:24:31 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 14:24:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc6907b3ed191bd6b90978ba9572cc7e4f951798
Cr-Commit-Position: refs/heads/master@{#28841}

Powered by Google App Engine
This is Rietveld 408576698