Revert of Only record one in n line endings to save space.

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 14283 matching lines @@
     // This is the source string inside the eval which has the call to baz.
     checkStackFrame(NULL, "", 1, 1, is_eval, false, stackTrace->GetFrame(2));
     // The last frame is an anonymous function which has the initial eval call.
     checkStackFrame(origin, "", 10, 1, false, false, stackTrace->GetFrame(3));
 
     CHECK(stackTrace->AsArray()->IsArray());
   }
 }
 
 
-void ChangeNewlines(int kind, char* dest, size_t dest_len, const char* source) {
-  if (kind == 0) {
-    for (size_t i = 0; i <= strlen(source); i++) {
-      dest[i] = source[i];
-    }
-  } else {
-    for (size_t i = 0; i <= strlen(source); i++) {
-      char c = source[i];
-      if (c == '\n') {
-        if (kind == 1) {
-          *dest++ = '\r';
-          *dest++ = '\n';
-        } else {
-          // UTF-8 version of 0x2028 newline.
-          *dest++ = '\xe2';
-          *dest++ = '\x80';
-          *dest++ = '\xa8';
-        }
-      } else {
-        *dest++ = c;
-      }
-    }
-  }
-}
-
-
 // Tests the C++ StackTrace API.
 // TODO(3074796): Reenable this as a THREADED_TEST once it passes.
 // THREADED_TEST(CaptureStackTrace) {
 TEST(CaptureStackTrace) {
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope scope(isolate);
   v8::Handle<v8::String> origin =
       v8::String::NewFromUtf8(isolate, "capture-stack-trace-test");
   Local<ObjectTemplate> templ = ObjectTemplate::New(isolate);
   templ->Set(v8_str("AnalyzeStackInNativeCode"),
              v8::FunctionTemplate::New(isolate, AnalyzeStackInNativeCode));
   LocalContext context(0, templ);
 
-  for (int i = 0; i < 3; i++) {
-    // Test getting OVERVIEW information. Should ignore information that is not
-    // script name, function name, line number, and column offset.
-    const char* overview_source =
-        "function bar() {\n"
-        "  var y; AnalyzeStackInNativeCode(1);\n"
-        "}\n"
-        "function foo() {\n"
-        "\n"
-        "  bar();\n"
-        "}\n"
-        "var x;eval('new foo();');";
-    size_t munged_length = strlen(overview_source) * 3 + 1;
-    char* overview_munged_source = new char[munged_length];
-    ChangeNewlines(i, overview_munged_source, munged_length, overview_source);
+  // Test getting OVERVIEW information. Should ignore information that is not
+  // script name, function name, line number, and column offset.
+  const char *overview_source =
+    "function bar() {\n"
+    "  var y; AnalyzeStackInNativeCode(1);\n"
+    "}\n"
+    "function foo() {\n"
+    "\n"
+    "  bar();\n"
+    "}\n"
+    "var x;eval('new foo();');";
+  v8::Handle<v8::String> overview_src =
+      v8::String::NewFromUtf8(isolate, overview_source);
+  v8::ScriptCompiler::Source script_source(overview_src,
+                                           v8::ScriptOrigin(origin));
+  v8::Handle<Value> overview_result(
+      v8::ScriptCompiler::CompileUnbound(isolate, &script_source)
+          ->BindToCurrentContext()
+          ->Run());
+  CHECK(!overview_result.IsEmpty());
+  CHECK(overview_result->IsObject());
 
-    v8::Handle<v8::String> overview_src =
-        v8::String::NewFromUtf8(isolate, overview_munged_source);
-    delete[] overview_munged_source;
-    v8::ScriptCompiler::Source script_source(overview_src,
-                                             v8::ScriptOrigin(origin));
-    v8::Handle<Value> overview_result(
-        v8::ScriptCompiler::CompileUnbound(isolate, &script_source)
-            ->BindToCurrentContext()
-            ->Run());
-    CHECK(!overview_result.IsEmpty());
-    CHECK(overview_result->IsObject());
-
-    // Test getting DETAILED information.
-    const char* detailed_source =
-        "function bat() {AnalyzeStackInNativeCode(2);\n"
-        "}\n"
-        "\n"
-        "function baz() {\n"
-        "  bat();\n"
-        "}\n"
-        "eval('new baz();');";
-    munged_length = strlen(detailed_source) * 3 + 1;
-    char* detailed_munged_source = new char[munged_length];
-    ChangeNewlines(i, detailed_munged_source, munged_length, detailed_source);
-    v8::Handle<v8::String> detailed_src =
-        v8::String::NewFromUtf8(isolate, detailed_munged_source);
-    delete[] detailed_munged_source;
-    // Make the script using a non-zero line and column offset.
-    v8::Handle<v8::Integer> line_offset = v8::Integer::New(isolate, 3);
-    v8::Handle<v8::Integer> column_offset = v8::Integer::New(isolate, 5);
-    v8::ScriptOrigin detailed_origin(origin, line_offset, column_offset);
-    v8::ScriptCompiler::Source script_source2(detailed_src, detailed_origin);
-    v8::Handle<v8::UnboundScript> detailed_script(
-        v8::ScriptCompiler::CompileUnbound(isolate, &script_source2));
-    v8::Handle<Value> detailed_result(
-        detailed_script->BindToCurrentContext()->Run());
-    CHECK(!detailed_result.IsEmpty());
-    CHECK(detailed_result->IsObject());
-  }
+  // Test getting DETAILED information.
+  const char *detailed_source =
+    "function bat() {AnalyzeStackInNativeCode(2);\n"
+    "}\n"
+    "\n"
+    "function baz() {\n"
+    "  bat();\n"
+    "}\n"
+    "eval('new baz();');";
+  v8::Handle<v8::String> detailed_src =
+      v8::String::NewFromUtf8(isolate, detailed_source);
+  // Make the script using a non-zero line and column offset.
+  v8::Handle<v8::Integer> line_offset = v8::Integer::New(isolate, 3);
+  v8::Handle<v8::Integer> column_offset = v8::Integer::New(isolate, 5);
+  v8::ScriptOrigin detailed_origin(origin, line_offset, column_offset);
+  v8::ScriptCompiler::Source script_source2(detailed_src, detailed_origin);
+  v8::Handle<v8::UnboundScript> detailed_script(
+      v8::ScriptCompiler::CompileUnbound(isolate, &script_source2));
+  v8::Handle<Value> detailed_result(
+      detailed_script->BindToCurrentContext()->Run());
+  CHECK(!detailed_result.IsEmpty());
+  CHECK(detailed_result->IsObject());
 }
 
 
 static void StackTraceForUncaughtExceptionListener(
     v8::Handle<v8::Message> message,
     v8::Handle<Value>) {
   report_count++;
   v8::Handle<v8::StackTrace> stack_trace = message->GetStackTrace();
   CHECK_EQ(2, stack_trace->GetFrameCount());
   checkStackFrame("origin", "foo", 2, 3, false, false,
@@ skipping 7046 matching lines @@
   CHECK_EQ(2U, set->Size());
 
   v8::Local<v8::Array> keys = set->AsArray();
   CHECK_EQ(2U, keys->Length());
   CHECK_EQ(1, keys->Get(0).As<v8::Int32>()->Value());
   CHECK_EQ(2, keys->Get(1).As<v8::Int32>()->Value());
 
   set = v8::Set::FromArray(env.local(), keys).ToLocalChecked();
   CHECK_EQ(2U, set->Size());
 }