chrome/browser/ui/omnibox/omnibox_edit_model.cc - Issue 1155673002: Omnibox - Add About Flag to Reverse Title and URLs in the Dropdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 1155673002: Omnibox - Add About Flag to Reverse Title and URLs in the Dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: peter's comments, including refactoring Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.cc ('k') | components/omnibox/autocomplete_match.h » ('j') | components/omnibox/autocomplete_result.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

index 88a54fc7296f6bd280a6dfba10519c04c6535299..69b4f5b9e37d7d38111ced970d91743218cc2e39 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

@@ -783,7 +783,7 @@ void OmniboxEditModel::OpenMatch(AutocompleteMatch match,

ACMatches fake_single_entry_matches;

fake_single_entry_matches.push_back(match);

AutocompleteResult fake_single_entry_result;

- fake_single_entry_result.AppendMatches(fake_single_entry_matches);

+ fake_single_entry_result.AppendMatches(input_, fake_single_entry_matches);

OmniboxLog log(

input_text,

just_deleted_text_,