Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: components/omnibox/autocomplete_result.h

Issue 1155673002: Omnibox - Add About Flag to Reverse Title and URLs in the Dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: peter's comments, including refactoring Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/autocomplete_result.h
diff --git a/components/omnibox/autocomplete_result.h b/components/omnibox/autocomplete_result.h
index 6681581647dc5ee6a1e352fbbd0decbd73001ced..6c065dc603d5dd00109e7c0186eb19590f89fcba 100644
--- a/components/omnibox/autocomplete_result.h
+++ b/components/omnibox/autocomplete_result.h
@@ -69,8 +69,12 @@ class AutocompleteResult {
const AutocompleteResult& old_matches,
TemplateURLService* template_url_service);
- // Adds a new set of matches to the result set. Does not re-sort.
- void AppendMatches(const ACMatches& matches);
+ // Adds a new set of matches to the result set. Does not re-sort. May
+ // transform the matches while adding them to make them better fit with the
+ // result set. Whether the transformation happens and how it does can
+ // change depending on |input|.
Peter Kasting 2015/05/22 23:39:36 Nit: These last two sentences are vague. I'd just
Mark P 2015/05/23 20:32:13 I slightly prefer the vagueness because I want to
+ void AppendMatches(const AutocompleteInput& input,
+ const ACMatches& matches);
// Removes duplicates, puts the list in sorted order and culls to leave only
// the best kMaxMatches matches. Sets the default match to the best match

Powered by Google App Engine
This is Rietveld 408576698