Adding UMA for persistent notifications.

chrome/browser/notifications/platform_notification_service_impl.cc

Index: chrome/browser/notifications/platform_notification_service_impl.cc
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 56908d85b8691880bd8035162cc15555a6b986cf..57938091de591b1d1535686a34c989b2827d7e89 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 
+#include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
@@ -52,15 +53,17 @@ namespace {
 // Callback to provide when deleting the data associated with persistent Web
 // Notifications from the notification database.
 void OnPersistentNotificationDataDeleted(bool success) {
-  // TODO(peter): Record UMA for notification deletion requests created by the
-  // PlatformNotificationService.
+  UMA_HISTOGRAM_BOOLEAN(
+      "PlatformNotificationService.PersistentNotificationDataDeleted", success);

[Peter Beverloo, 2015/05/22 13:40:34]

These need to be added to tools/metrics/histograms/histograms.xml, otherwise
they won't actually show up in the dashboards.

[Deepak, 2015/05/22 14:09:29]

Done.

 }
 
 // Persistent notifications fired through the delegate do not care about the
 // lifetime of the Service Worker responsible for executing the event.
 void OnEventDispatchComplete(content::PersistentNotificationStatus status) {
-  // TODO(peter): Record UMA statistics about the result status of running
-  // events for persistent Web Notifications.
+  UMA_HISTOGRAM_BOOLEAN(
+      "PlatformNotificationService.PersistentWebNotificationComplete",

[Peter Beverloo, 2015/05/22 13:40:34]

Why wouldn't we record all states of |status| here using
UMA_HISTOGRAM_ENUMERATION? Sorry if that wasn't clear.

[Peter Beverloo, 2015/05/22 13:40:35]

naming nit: PNS.PersistentWebNotificationClickResult?

[Deepak, 2015/05/22 14:09:29]

Done.

+      content::PersistentNotificationStatus::
+              PERSISTENT_NOTIFICATION_STATUS_SUCCESS == status);

[Peter Beverloo, 2015/05/22 13:40:35]

nit: indentation.

[Deepak, 2015/05/22 14:09:29]

ok, I will run 'git cl format' for checking indentation.
Thanks

 }
 
 void CancelNotification(const std::string& id, ProfileID profile_id) {