Adding UMA for persistent notifications.

chrome/browser/notifications/platform_notification_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 
+#include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
 #include "chrome/browser/notifications/notification_object_proxy.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/notifications/persistent_notification_delegate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/common/pref_names.h"
@@ skipping 28 matching lines @@
 using content::BrowserContext;
 using content::BrowserThread;
 using content::PlatformNotificationContext;
 using message_center::NotifierId;
 
 namespace {
 
 // Callback to provide when deleting the data associated with persistent Web
 // Notifications from the notification database.
 void OnPersistentNotificationDataDeleted(bool success) {
-  // TODO(peter): Record UMA for notification deletion requests created by the
-  // PlatformNotificationService.
+  UMA_HISTOGRAM_BOOLEAN(
+      "PlatformNotificationService.PersistentNotificationDataDeleted", success);

[Peter Beverloo, 2015/05/22 13:40:34]

These need to be added to tools/metrics/histograms/histograms.xml, otherwise
they won't actually show up in the dashboards.

[Deepak, 2015/05/22 14:09:29]

Done.

 }
 
 // Persistent notifications fired through the delegate do not care about the
 // lifetime of the Service Worker responsible for executing the event.
 void OnEventDispatchComplete(content::PersistentNotificationStatus status) {
-  // TODO(peter): Record UMA statistics about the result status of running
-  // events for persistent Web Notifications.
+  UMA_HISTOGRAM_BOOLEAN(
+      "PlatformNotificationService.PersistentWebNotificationComplete",

[Peter Beverloo, 2015/05/22 13:40:34]

Why wouldn't we record all states of |status| here using
UMA_HISTOGRAM_ENUMERATION? Sorry if that wasn't clear.

[Peter Beverloo, 2015/05/22 13:40:35]

naming nit: PNS.PersistentWebNotificationClickResult?

[Deepak, 2015/05/22 14:09:29]

Done.

+      content::PersistentNotificationStatus::
+              PERSISTENT_NOTIFICATION_STATUS_SUCCESS == status);

[Peter Beverloo, 2015/05/22 13:40:35]

nit: indentation.

[Deepak, 2015/05/22 14:09:29]

ok, I will run 'git cl format' for checking indentation.
Thanks

 }
 
 void CancelNotification(const std::string& id, ProfileID profile_id) {
   PlatformNotificationServiceImpl::GetInstance()
       ->GetNotificationUIManager()->CancelById(id, profile_id);
 }
 
 }  // namespace
 
 // static
@@ skipping 333 matching lines @@
       formatted_origin.push_back(':');
       formatted_origin.append(base::UTF8ToUTF16(origin.port()));
     }
     return formatted_origin;
   }
 
   // TODO(dewittj): Once file:// URLs are passed in to the origin
   // GURL here, begin returning the path as the display name.
   return net::FormatUrl(origin, languages);
 }