Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

chrome/browser/notifications/notification_ui_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_UI_MANAGER_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_UI_MANAGER_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 49 matching lines @@
 
   // Removes any notifications matching the supplied ID, either currently
   // displayed or in the queue.  Returns true if anything was removed.
   // This function can be bound for delayed execution, where a profile pointer
   // may not be valid. Hence caller needs to call the static GetProfileID(...)
   // function to turn a profile pointer into a profile id and pass that in.
   virtual bool CancelById(const std::string& delegate_id,
                           ProfileID profile_id) = 0;
 
   // Returns the set of all delegate IDs for notifications from the passed
-  // |profile| and |source|.
-  // TODO(peter): Change Profile* to ProfileID to clarify that the profile
-  // should not be used for making any calls, as it might be dead.
+  // |profile_id| and |source|.
   virtual std::set<std::string> GetAllIdsByProfileAndSourceOrigin(
-      Profile* profile,
+      ProfileID profile_id,
       const GURL& source) = 0;
 
-  // Returns the set of all delegate IDs for notifications from |profile|.
-  // TODO(peter): Change Profile* to ProfileID to clarify that the profile
-  // should not be used for making any calls, as it might be dead.
-  virtual std::set<std::string> GetAllIdsByProfile(Profile* profile) = 0;
+  // Returns the set of all delegate IDs for notifications from |profile_id|.
+  virtual std::set<std::string> GetAllIdsByProfile(ProfileID profile_id) = 0;

[dewittj, 2015/05/27 18:22:39]

I think there is at least one callsite of this function
(platform_notification_service_impl.cc) that needs to use GetProfileId now.

[Deepak, 2015/05/28 05:37:08]

Done.

 
   // Removes notifications matching the |source_origin| (which could be an
   // extension ID). Returns true if anything was removed.
   virtual bool CancelAllBySourceOrigin(const GURL& source_origin) = 0;
 
   // Removes notifications matching |profile_id|. Returns true if any were
   // removed.
   virtual bool CancelAllByProfile(ProfileID profile_id) = 0;
 
   // Cancels all pending notifications and closes anything currently showing.
   // Used when the app is terminating.
   virtual void CancelAll() = 0;
 
  protected:
   NotificationUIManager() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(NotificationUIManager);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_UI_MANAGER_H_