Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 1155443009: [Sync] Rename SyncActive to IsSyncActive. (Closed)

Created:
5 years, 6 months ago by maxbogue
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, vabr+watchlist_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename SyncActive to IsSyncActive. This is part of an effort to clean up sync's state interface. BUG=495192 TBR=bauerb,benwells,msw,sdefresne Committed: https://crrev.com/192b36003ecd4265667c3625d06948bb7c3d1582 Cr-Commit-Position: refs/heads/master@{#332752}

Patch Set 1 #

Patch Set 2 : Fix merge misses. #

Patch Set 3 : More non-android cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -74 lines) Patch
M chrome/browser/android/foreign_session_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/most_visited_sites.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preferences_private/preferences_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/web_history_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/web_history_service_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/sync/about_sync_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_delete_directives_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 13 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/sync/sync_startup_tracker.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_auth_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/app_sync_ui_state.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_observer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/options_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/sync_service.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
maxbogue
PTAL; first steps of the state refactoring.
5 years, 6 months ago (2015-06-02 17:10:48 UTC) #2
vabr (Chromium)
*/password_manager/* LGTM. Also thanks for the style fixes! Vaclav
5 years, 6 months ago (2015-06-02 17:29:47 UTC) #4
Nicolas Zea
lgtm
5 years, 6 months ago (2015-06-03 17:29:56 UTC) #5
maxbogue
Used git cl owners to generate this list. I'll be TBR'ing the remaining ones since ...
5 years, 6 months ago (2015-06-03 21:06:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155443009/40001
5 years, 6 months ago (2015-06-03 21:09:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/63889)
5 years, 6 months ago (2015-06-03 22:18:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155443009/40001
5 years, 6 months ago (2015-06-03 23:42:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-04 00:34:01 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 00:34:51 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/192b36003ecd4265667c3625d06948bb7c3d1582
Cr-Commit-Position: refs/heads/master@{#332752}

Powered by Google App Engine
This is Rietveld 408576698