chrome/browser/ui/sync/one_click_signin_sync_observer.cc - Issue 1155443009: [Sync] Rename SyncActive to IsSyncActive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer.cc

Issue 1155443009: [Sync] Rename SyncActive to IsSyncActive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More non-android cases. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_sync_observer.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer.cc b/chrome/browser/ui/sync/one_click_signin_sync_observer.cc

index 3f911fccecafa99ac369decbfce433b6ca2c6436..e8ff4480f9ef9d65041156c0d7de1a2c96b4d11f 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_observer.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer.cc

@@ -78,7 +78,7 @@ void OneClickSigninSyncObserver::OnStateChanged() {

return;

}

- if (sync_service->SyncActive() &&

+ if (sync_service->IsSyncActive() &&

signin::GetSourceForPromoURL(continue_url_)

!= signin_metrics::SOURCE_SETTINGS) {

// TODO(isherman): Having multiple settings pages open can cause issues