change internals over to SkPixmap and stop using accessBitmap

change internals over to SkPixmap and stop using accessBitmap

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/884e97cb04db7ed053a866567ee9c6e4c01f993a

[reed1, 2015-05-26 16:17:44]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-26 16:17:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155443004/1

[commit-bot: I haz the power, 2015-05-26 16:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-26 16:24:02]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-05-26 18:17:26]

reed@google.com changed reviewers:
+ scroggo@google.com

[reed1, 2015-05-26 18:17:34]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-05-26 18:17:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155443004/1

[commit-bot: I haz the power, 2015-05-26 18:17:47]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-05-27 00:17 UTC

[scroggo, 2015-05-26 18:30:31]

lgtm

https://codereview.chromium.org/1155443004/diff/1/src/core/SkPixmap.cpp
File src/core/SkPixmap.cpp (right):

https://codereview.chromium.org/1155443004/diff/1/src/core/SkPixmap.cpp#newco...
src/core/SkPixmap.cpp:31: if (addr) {
It seems like if addr is NULL, the rest of these aren't meaningful. Should we
just reset() it in that case? Or is there a valid case I am missing?

[commit-bot: I haz the power, 2015-05-26 18:31:59]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/884e97cb04db7ed053a866567ee9c6e4c01f993a

[reed1, 2015-05-26 18:45:25]

https://codereview.chromium.org/1155443004/diff/1/src/core/SkPixmap.cpp
File src/core/SkPixmap.cpp (right):

https://codereview.chromium.org/1155443004/diff/1/src/core/SkPixmap.cpp#newco...
src/core/SkPixmap.cpp:31: if (addr) {
On 2015/05/26 18:30:31, scroggo wrote:
> It seems like if addr is NULL, the rest of these aren't meaningful. Should we
> just reset() it in that case? Or is there a valid case I am missing?

Yea, still "evolving" what I think we should enforce about the validity of the
fields. SkImageInfo tries to keep self-consistent to some degree, so perhaps we
should add some of that here as well (which may mean removing the constructor
and using a factory instead, so it can "clean things up" before creating the
instance).

[scroggo, 2015-05-26 19:15:55]

scroggo@google.com changed reviewers:
+ djsollen@google.com, tomhudson@google.com

[scroggo, 2015-05-26 19:15:55]

This broke the Android build:

https://android-build.storage.googleapis.com/builds/git_master-skia-linux-raz...

This happened because the API for some of SkCanvas' virtual functions changed.
Tom and/or Derek, can we build these files under some target (maybe with the
meat #ifdef'ed out, in the case of things that depend on HWUI) so we can catch a
build error like this before submitting?