include/core/SkCanvas.h - Issue 1155443004: change internals over to SkPixmap and stop using accessBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkCanvas.h

Issue 1155443004: change internals over to SkPixmap and stop using accessBitmap (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkCanvas.h

diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h

index e7dac5e145f726cd35a92b8a966cf46ea5e6088f..dda049654e3c5d3d813057444f23ea80308fa974 100644

--- a/include/core/SkCanvas.h

+++ b/include/core/SkCanvas.h

@@ -1156,8 +1156,8 @@ protected:

virtual SkSurface* onNewSurface(const SkImageInfo&, const SkSurfaceProps&);

// default impl defers to its device

- virtual const void* onPeekPixels(SkImageInfo*, size_t* rowBytes);

- virtual void* onAccessTopLayerPixels(SkImageInfo*, size_t* rowBytes);

+ virtual bool onPeekPixels(SkPixmap*);

+ virtual bool onAccessTopLayerPixels(SkPixmap*);

// Subclass save/restore notifiers.

// Overriders should call the corresponding INHERITED method up the inheritance chain.