<webview>: Add name attribute

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 87f363f06eb70bea097adf39f69ab768ec2d662c..17e4c49f04a21c275ef97dde2faac7d2d0e2fb8f 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -940,6 +940,7 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
     IPC_MESSAGE_HANDLER(ViewMsg_PasteAndMatchStyle, OnPasteAndMatchStyle)
     IPC_MESSAGE_HANDLER(ViewMsg_Replace, OnReplace)
     IPC_MESSAGE_HANDLER(ViewMsg_Delete, OnDelete)
+    IPC_MESSAGE_HANDLER(ViewMsg_SetName, OnSetName)
     IPC_MESSAGE_HANDLER(ViewMsg_SelectAll, OnSelectAll)
     IPC_MESSAGE_HANDLER(ViewMsg_Unselect, OnUnselect)
     IPC_MESSAGE_HANDLER(ViewMsg_SetEditableSelectionOffsets,
@@ -1362,6 +1363,13 @@ void RenderViewImpl::OnDelete() {
   webview()->focusedFrame()->executeCommand(WebString::fromUTF8("Delete"));
 }
 
+void RenderViewImpl::OnSetName(const std::string& name) {
+  if (!webview())
+    return;
+
+  webview()->mainFrame()->setName(WebString::fromUTF8(name));
+}
+
 void RenderViewImpl::OnSelectAll() {
   if (!webview())
     return;
@@ -2712,6 +2720,14 @@ void RenderViewImpl::willClose(WebFrame* frame) {
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, FrameWillClose(frame));
 }
 
+void RenderViewImpl::didChangeName(WebFrame* frame,
+                                   const WebString& name)  {
+  Send(new ViewHostMsg_UpdateFrameName(routing_id_,
+                                       frame->identifier(),
+                                       !frame->parent(),
+                                       UTF16ToUTF8(name)));

[Charlie Reis, 2013/01/04 21:36:33]

Just checking: are we ok with this conversion?  I'm not sure what the rules are
on name strings.  It could potentially prevent windows with non-UTF8 names from
being found.

[Fady Samuel, 2013/01/08 16:19:07]

Judging by this: http://www.w3.org/TR/html4/present/frames.html#adef-name-FRAME

and this: http://www.w3.org/TR/html4/types.html#type-cdata

It seems this is our answer:

"ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by
any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons
(":"), and periods (".")."

It sounds like we don't need to keep this name in a string16 to do what a
frame's name can do.

[Charlie Reis, 2013/01/08 21:18:45]

Great!  Thanks for verifying.

+}
+
 void RenderViewImpl::loadURLExternally(
     WebFrame* frame, const WebURLRequest& request,
     WebNavigationPolicy policy) {