Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 11554030: <webview>: Add name attribute (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with ToT and back to plumbing directly to BrowserPlugin instead of through WebContents Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 2b16281fc4f9c3b3d9a25367e01bb9d04a810dfd..5892cf53d2b6bdc611437fd1f2ece5ae74694c75 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -222,6 +222,9 @@ class CONTENT_EXPORT BrowserPluginGuest : public NotificationObserver,
const BrowserPluginHostMsg_ResizeGuest_Params& resize_guest_params);
// Overriden in tests.
virtual void OnSetFocus(int instance_id, bool focused);
+ // Sets the name of the guest so that other guests of the same partition can
Charlie Reis 2013/01/04 21:36:33 nit: guests in the same partition
Fady Samuel 2013/01/08 16:19:07 Done.
+ // access it.
+ void OnSetName(int instance_id, const std::string& name);
// The guest WebContents is visible if both its embedder is visible and
// the browser plugin element is visible. If either one is not then the
// WebContents is marked as hidden. A hidden WebContents will consume
@@ -263,6 +266,9 @@ class CONTENT_EXPORT BrowserPluginGuest : public NotificationObserver,
// Overriden in tests.
virtual void OnTakeFocus(bool reverse);
void OnUpdateDragCursor(WebKit::WebDragOperation operation);
+ void OnUpdateFrameName(int frame_id,
+ bool is_top_level,
+ const std::string& name);
void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);
// Static factory instance (always NULL for non-test).
@@ -284,6 +290,7 @@ class CONTENT_EXPORT BrowserPluginGuest : public NotificationObserver,
base::TimeDelta guest_hang_timeout_;
bool focused_;
bool visible_;
+ std::string name_;
bool auto_size_enabled_;
gfx::Size max_auto_size_;
gfx::Size min_auto_size_;

Powered by Google App Engine
This is Rietveld 408576698