Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1155273004: Remove PasswordAuthenticationManager.java file that is no longer used. (Closed)

Created:
5 years, 7 months ago by abhi.rathore
Modified:
5 years, 6 months ago
CC:
chromium-reviews, Abhishek, Jitu( very slow this week)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PasswordAuthenticationManager.java file that is no longer used. Patch [1] removed the password manager related code from Android. This CL cleans up the remaining traces of it by removing the PasswordAuthenticationManager.java which is still part of the repository. [1] https://codereview.chromium.org/641753002 BUG=NONE Committed: https://crrev.com/eca9c4be0e1a28edb3752d697c0f16e47c94bd8c Cr-Commit-Position: refs/heads/master@{#331772}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -131 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java View 1 chunk +0 lines, -130 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
abhi.rathore
PTAL!
5 years, 7 months ago (2015-05-27 12:55:00 UTC) #2
abhi.rathore
5 years, 7 months ago (2015-05-27 13:26:51 UTC) #4
aurimas (slooooooooow)
lgtm
5 years, 7 months ago (2015-05-27 15:45:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155273004/1
5 years, 6 months ago (2015-05-28 04:45:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/29044) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-05-28 04:49:18 UTC) #9
vivekg
@abhi, please rebase the patch as the bots are red due to patch failure.
5 years, 6 months ago (2015-05-28 04:56:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155273004/40001
5 years, 6 months ago (2015-05-28 05:26:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66465)
5 years, 6 months ago (2015-05-28 05:33:02 UTC) #15
abhi.rathore
@yaron PTAL: chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java
5 years, 6 months ago (2015-05-28 05:46:50 UTC) #17
Yaron
lgtm
5 years, 6 months ago (2015-05-28 13:11:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155273004/40001
5 years, 6 months ago (2015-05-28 13:13:49 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-28 13:18:19 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 13:19:06 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eca9c4be0e1a28edb3752d697c0f16e47c94bd8c
Cr-Commit-Position: refs/heads/master@{#331772}

Powered by Google App Engine
This is Rietveld 408576698