Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 115523010: Always clear callback after WaveOut Stop(). (Closed)

Created:
6 years, 11 months ago by DaleCurtis
Modified:
6 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Always clear callback after WaveOut Stop(). If an error occurs after Stop() the callback may be destroyed, yet the callback value was not cleared. During Close() stop may be called again, if an error occurs the free'd callback will be notified of the error... BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243649

Patch Set 1 #

Patch Set 2 : Fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M media/audio/win/waveout_output_win.cc View 1 1 chunk +5 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
DaleCurtis
Found a few crashes while digging through reports.
6 years, 11 months ago (2014-01-07 01:44:54 UTC) #1
henrika (OOO until Aug 14)
Please forgive me if I am slow here but I am unable to see where ...
6 years, 11 months ago (2014-01-07 08:45:25 UTC) #2
DaleCurtis
See line 280. Previously the code could return early without clearing the callback.
6 years, 11 months ago (2014-01-07 18:34:55 UTC) #3
DaleCurtis
Err, line 272 now. My first patch was completely wrong! I misread the UnregisterWaitEx documentation. ...
6 years, 11 months ago (2014-01-07 18:54:41 UTC) #4
henrika (OOO until Aug 14)
LGTM. Thanks Dale.
6 years, 11 months ago (2014-01-08 08:51:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/115523010/50001
6 years, 11 months ago (2014-01-08 18:40:27 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 21:36:34 UTC) #7
Message was sent while issue was closed.
Change committed as 243649

Powered by Google App Engine
This is Rietveld 408576698