Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 1155163002: Add missing BASE_EXPORT to LogErrorNotReached(). (Closed)

Created:
5 years, 7 months ago by Thiemo Nagel
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, erikwright+watch_chromium.org, Shu Chen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing BASE_EXPORT to LogErrorNotReached(). This fixes a linker error that was introduced in https://codereview.chromium.org/1124673004/. BUG=484283 TBR=danakj@chromium.org Committed: https://crrev.com/80388e68135256245a4f44b4c161136cf5580847 Cr-Commit-Position: refs/heads/master@{#331354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/logging.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155163002/1
5 years, 7 months ago (2015-05-26 09:04:02 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/69536)
5 years, 7 months ago (2015-05-26 11:22:52 UTC) #4
Thiemo Nagel
On 2015/05/26 11:22:52, I haz the power - commit-bot wrote: > Try jobs failed on ...
5 years, 7 months ago (2015-05-26 11:29:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155163002/1
5 years, 7 months ago (2015-05-26 11:30:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 13:28:08 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 13:29:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80388e68135256245a4f44b4c161136cf5580847
Cr-Commit-Position: refs/heads/master@{#331354}

Powered by Google App Engine
This is Rietveld 408576698