Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: src/api.cc

Issue 1155043005: Fix compile warning [-Wtype-limits] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 994429a013426463dd82c29a00664612a85ba010..f0f33acc0b7e40dc85ab13f36ab3512cde7d41b1 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7211,7 +7211,7 @@ bool Isolate::GetHeapSpaceStatistics(HeapSpaceStatistics* space_statistics,
size_t index) {
if (!space_statistics)
return false;
- if (index > i::LAST_SPACE || index < i::FIRST_SPACE)
+ if (index > i::LAST_SPACE || (i::FIRST_SPACE > 0 && index < i::FIRST_SPACE))
vogelheim 2015/06/05 08:30:43 The way I read globals.h, i::FIRST_SPACE would usu
return false;
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698