Fix compile warning [-Wtype-limits]

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 7193 matching lines @@
 
 size_t Isolate::NumberOfHeapSpaces() {
   return i::LAST_SPACE - i::FIRST_SPACE + 1;
 }
 
 
 bool Isolate::GetHeapSpaceStatistics(HeapSpaceStatistics* space_statistics,
                                      size_t index) {
   if (!space_statistics)
     return false;
-  if (index > i::LAST_SPACE || index < i::FIRST_SPACE)
+  if (index > i::LAST_SPACE || (i::FIRST_SPACE > 0 && index < i::FIRST_SPACE))

[vogelheim, 2015/06/05 08:30:43]

The way I read globals.h, i::FIRST_SPACE would usually be 0, meaning this
effectively eliminates the 2nd condition.
Also, I'm not really sure why this would be the right place to make an assertion
about the i::FIRST_SPACE constant in the first place.

Would you care to explain a bit more what you're trying to do? I'm afraid I
don't quite get it.

     return false;
 
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
   i::Heap* heap = isolate->heap();
   i::Space* space = heap->space(static_cast<int>(index));
 
   space_statistics->space_name_ = heap->GetSpaceName(static_cast<int>(index));
   space_statistics->space_size_ = space->CommittedMemory();
   space_statistics->space_used_size_ = space->SizeOfObjects();
   space_statistics->space_available_size_ = space->Available();
@@ skipping 1161 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8