Issue 1154903003: "typedef Foo Bar" -> "using Bar = Foo" in //mojo/edk/....

Issue 1154903003: "typedef Foo Bar" -> "using Bar = Foo" in //mojo/edk/.... (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

"typedef Foo Bar" -> "using Bar = Foo" in //mojo/edk/.... The latter is now standard, and to be consistent (with new things I'll add), I guess I should convert everything. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9acf1aa58b861bb77632b7c8a4c0ee3d35c8da9c

Patch Set 1 #

Total comments: 4

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -50 lines)			Patch
M	mojo/edk/embedder/embedder.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/edk/embedder/embedder_internal.h	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	mojo/edk/embedder/master_process_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/embedder/platform_channel_pair.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/embedder/platform_handle_vector.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/edk/js/drain_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/async_waiter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/awakable_list.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/channel.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	mojo/edk/system/channel_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/connection_manager.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/core_test_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/core_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/data_pipe_impl_unittest.cc	View	1 chunk	+5 lines, -5 lines	2 comments	Download
M	mojo/edk/system/dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/handle_table.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/mapping_table.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/memory.h	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	mojo/edk/system/message_in_transit.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/options_validation_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/test/multiprocess_test_helper_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/1154903003/diff/1/mojo/edk/embedder/embedder_internal.h File mojo/edk/embedder/embedder_internal.h (right): https://codereview.chromium.org/1154903003/diff/1/mojo/edk/embedder/embedder_internal.h#newcode27 mojo/edk/embedder/embedder_internal.h:27: // Duplicate from mojo/edk/system/channel_manager.h, to avoid including it. ...

5 years, 7 months ago (2015-05-22 18:16:04 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/1154903003/diff/1/mojo/edk/embedder/embedder_internal.h File mojo/edk/embedder/embedder_internal.h (right): https://codereview.chromium.org/1154903003/diff/1/mojo/edk/embedder/embedder_internal.h#newcode27 mojo/edk/embedder/embedder_internal.h:27: // Duplicate from mojo/edk/system/channel_manager.h, to avoid including it. ...

5 years, 7 months ago (2015-05-22 18:24:27 UTC) #3

viettrungluu

5 years, 7 months ago (2015-05-22 18:24:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9acf1aa58b861bb77632b7c8a4c0ee3d35c8da9c (presubmit successful).

Expand Messages | Collapse Messages