Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: mojo/edk/system/options_validation_unittest.cc

Issue 1154903003: "typedef Foo Bar" -> "using Bar = Foo" in //mojo/edk/.... (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/system/options_validation.h" 5 #include "mojo/edk/system/options_validation.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "mojo/public/c/system/macros.h" 10 #include "mojo/public/c/system/macros.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace mojo { 13 namespace mojo {
14 namespace system { 14 namespace system {
15 namespace { 15 namespace {
16 16
17 // Declare a test options struct just as we do in actual public headers. 17 // Declare a test options struct just as we do in actual public headers.
18 18
19 typedef uint32_t TestOptionsFlags; 19 using TestOptionsFlags = uint32_t;
20 20
21 static_assert(MOJO_ALIGNOF(int64_t) == 8, "int64_t has weird alignment"); 21 static_assert(MOJO_ALIGNOF(int64_t) == 8, "int64_t has weird alignment");
22 struct MOJO_ALIGNAS(8) TestOptions { 22 struct MOJO_ALIGNAS(8) TestOptions {
23 uint32_t struct_size; 23 uint32_t struct_size;
24 TestOptionsFlags flags; 24 TestOptionsFlags flags;
25 uint32_t member1; 25 uint32_t member1;
26 uint32_t member2; 26 uint32_t member2;
27 }; 27 };
28 static_assert(sizeof(TestOptions) == 16, "TestOptions has wrong size"); 28 static_assert(sizeof(TestOptions) == 16, "TestOptions has wrong size");
29 29
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 : reinterpret_cast<TestOptions*>(&buffer[0]); 121 : reinterpret_cast<TestOptions*>(&buffer[0]);
122 options->struct_size = static_cast<uint32_t>(sizeof(TestOptions)); 122 options->struct_size = static_cast<uint32_t>(sizeof(TestOptions));
123 UserOptionsReader<TestOptions> reader(MakeUserPointer(options)); 123 UserOptionsReader<TestOptions> reader(MakeUserPointer(options));
124 }, 124 },
125 kMemoryCheckFailedRegex); 125 kMemoryCheckFailedRegex);
126 } 126 }
127 127
128 } // namespace 128 } // namespace
129 } // namespace system 129 } // namespace system
130 } // namespace mojo 130 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698