Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 11548010: Revert 172470 (Closed)

Created:
8 years ago by Nico
Modified:
8 years ago
Reviewers:
adamk
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 172470 Likely caused this: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/4984/steps/browser_tests/logs/Iframe ExtensionResourceRequestPolicyTest.Iframe: ASSERTION FAILED: equalIgnoringFragmentIdentifier(initialRequest.url(), request.url()) ../../third_party/WebKit/Source/WebCore/loader/MainResourceLoader.cpp(656) : void WebCore::MainResourceLoader::load(const WebCore::ResourceRequest &, const WebCore::SubstituteData &) [3510:-1256083456:1211/172350:916009739873:WARNING:extension_protocols.cc(344)] Failed to GetPathForExtension: invalid [3510:-1256083456:1211/172350:916009829652:WARNING:url_request_job_manager.cc(131)] Failed to map: chrome-extension://invalid/ 1 0x12883e9e WebCore::MainResourceLoader::load(WebCore::ResourceRequest const&, WebCore::SubstituteData const&) [3510:-1408298304:1211/172350:916021817738:INFO:CONSOLE(0)] "Denying load of chrome-extension://pbkkcbgdkliohhfaeefcijaghglkahja/inaccessible-iframe-contents.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0) 2 0x1281e972 WebCore::DocumentLoader::startLoadingMainResource() 3 0x1286293c WebCore::FrameLoader::continueLoadAfterWillSubmitForm() > Roll WebKit 137323:137364 > > TBR=podivilov@chromium.org > > Review URL: https://codereview.chromium.org/11553004 TBR=adamk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
8 years ago (2012-12-12 01:29:33 UTC) #1
adamk
8 years ago (2012-12-12 07:53:55 UTC) #2
Message was sent while issue was closed.
On 2012/12/12 01:29:33, Nico wrote:

lgtm

Sorry for the breakage (the Win7 dbg canary was just too slow for me, I guess).
This has all been rolled out now in http://trac.webkit.org/changeset/137424

Powered by Google App Engine
This is Rietveld 408576698